From 429dbbb2419c144131cd73c64c526f543a25615a Mon Sep 17 00:00:00 2001 From: Yuriy Artamonov Date: Sat, 21 Dec 2024 19:04:48 +0100 Subject: [PATCH] [platform] IJPL-174111 Stop spamming user logs with warnings on preloading of services GitOrigin-RevId: b1b18d1b14076586a41bc286c6448914f76c4761 --- .../com/intellij/serviceContainer/ComponentManagerImpl.kt | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/platform/service-container/src/com/intellij/serviceContainer/ComponentManagerImpl.kt b/platform/service-container/src/com/intellij/serviceContainer/ComponentManagerImpl.kt index e40103733f60..680f320ae3ad 100644 --- a/platform/service-container/src/com/intellij/serviceContainer/ComponentManagerImpl.kt +++ b/platform/service-container/src/com/intellij/serviceContainer/ComponentManagerImpl.kt @@ -16,6 +16,7 @@ import com.intellij.diagnostic.PluginException import com.intellij.diagnostic.StartUpMeasurer import com.intellij.ide.plugins.* import com.intellij.ide.plugins.cl.PluginAwareClassLoader +import com.intellij.idea.AppMode.isDevServer import com.intellij.idea.AppMode.isLightEdit import com.intellij.openapi.Disposable import com.intellij.openapi.application.* @@ -1064,7 +1065,12 @@ abstract class ComponentManagerImpl( LOG.error(PluginException(message, plugin.pluginId)) } else if (!isKnown || !impl.startsWith("com.intellij.")) { - LOG.warn(message) + if (ApplicationManager.getApplication().isUnitTestMode + || PluginManagerCore.isRunningFromSources() + || isDevServer()) { + // logged only during development, let's not spam users + LOG.warn(message) + } } }