From 4012d7e874a6984d82b75bc4df4c3cbd768259ca Mon Sep 17 00:00:00 2001
From: "Anna.Kozlova" <anna.kozlova@jetbrains.com>
Date: Thu, 20 Dec 2018 18:55:24 +0100
Subject: [PATCH] can be final: don't suggest private methods

---
 .../codeInspection/canBeFinal/CanBeFinalInspection.java        | 1 +
 .../testData/inspection/canBeFinal/SCR7737/src/A.java          | 3 +++
 2 files changed, 4 insertions(+)

diff --git a/java/java-analysis-impl/src/com/intellij/codeInspection/canBeFinal/CanBeFinalInspection.java b/java/java-analysis-impl/src/com/intellij/codeInspection/canBeFinal/CanBeFinalInspection.java
index 3bab2d10dd27..2da9ae49af01 100644
--- a/java/java-analysis-impl/src/com/intellij/codeInspection/canBeFinal/CanBeFinalInspection.java
+++ b/java/java-analysis-impl/src/com/intellij/codeInspection/canBeFinal/CanBeFinalInspection.java
@@ -133,6 +133,7 @@ public class CanBeFinalInspection extends GlobalJavaBatchInspectionTool {
       else if (refElement instanceof RefMethod) {
         RefMethod refMethod = (RefMethod)refElement;
         if (refMethod.getOwnerClass().isFinal()) return null;
+        if (psiMember.hasModifierProperty(PsiModifier.PRIVATE)) return null;
         if (!isReportMethods()) return null;
         psiIdentifier = ((PsiMethod)psiMember).getNameIdentifier();
       }
diff --git a/java/java-tests/testData/inspection/canBeFinal/SCR7737/src/A.java b/java/java-tests/testData/inspection/canBeFinal/SCR7737/src/A.java
index aee28c806e29..1988717d302f 100644
--- a/java/java-tests/testData/inspection/canBeFinal/SCR7737/src/A.java
+++ b/java/java-tests/testData/inspection/canBeFinal/SCR7737/src/A.java
@@ -1,6 +1,9 @@
 // A.java
 class A implements Runnable {
     public void run() {
+        a();
     }
+
+    private void a() {}
 }