From 3fda127a486c17aba6430f6e8856e13898240a28 Mon Sep 17 00:00:00 2001 From: Tagir Valeev Date: Wed, 24 May 2017 16:47:30 +0700 Subject: [PATCH] ComparatorResultComparisonInspection: renamed to "Suspicious usage of compare method" --- .../comparatorResultComparison/afterComparableVar.java | 2 +- .../comparatorResultComparison/beforeComparableVar.java | 2 +- .../src/messages/InspectionsBundle.properties | 3 ++- .../codeInspection/ComparatorResultComparisonInspection.java | 2 +- 4 files changed, 5 insertions(+), 4 deletions(-) diff --git a/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/comparatorResultComparison/afterComparableVar.java b/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/comparatorResultComparison/afterComparableVar.java index 06183fdd5091..5d93c76e75c5 100644 --- a/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/comparatorResultComparison/afterComparableVar.java +++ b/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/comparatorResultComparison/afterComparableVar.java @@ -1,4 +1,4 @@ -// "Fix all 'Comparison of compare method result with specific constant' problems in file" "true" +// "Fix all 'Suspicious usage of compare method' problems in file" "true" import java.util.*; class Test { diff --git a/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/comparatorResultComparison/beforeComparableVar.java b/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/comparatorResultComparison/beforeComparableVar.java index e6b4e5360bc9..b6b53bb95b41 100644 --- a/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/comparatorResultComparison/beforeComparableVar.java +++ b/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/comparatorResultComparison/beforeComparableVar.java @@ -1,4 +1,4 @@ -// "Fix all 'Comparison of compare method result with specific constant' problems in file" "true" +// "Fix all 'Suspicious usage of compare method' problems in file" "true" import java.util.*; class Test { diff --git a/platform/platform-resources-en/src/messages/InspectionsBundle.properties b/platform/platform-resources-en/src/messages/InspectionsBundle.properties index 3168fe550df9..0fe669492232 100644 --- a/platform/platform-resources-en/src/messages/InspectionsBundle.properties +++ b/platform/platform-resources-en/src/messages/InspectionsBundle.properties @@ -870,5 +870,6 @@ inspection.replace.with.trivial.lambda.fix.name=Replace with lambda returning '' inspection.useless.null.check.message=Useless null-check: {0} is never null inspection.useless.null.check.fix.family.name=Remove useless null-check -inspection.comparator.result.comparison.display.name=Comparison of compare method result with specific constant +inspection.comparator.result.comparison.display.name=Suspicious usage of compare method +inspection.comparator.result.comparison.problem.display.name=Comparison of compare method result with specific constant inspection.comparator.result.comparison.fix.family.name=Fix comparator result comparison diff --git a/plugins/InspectionGadgets/src/com/intellij/codeInspection/ComparatorResultComparisonInspection.java b/plugins/InspectionGadgets/src/com/intellij/codeInspection/ComparatorResultComparisonInspection.java index b5199c053703..56ef41f3bf79 100644 --- a/plugins/InspectionGadgets/src/com/intellij/codeInspection/ComparatorResultComparisonInspection.java +++ b/plugins/InspectionGadgets/src/com/intellij/codeInspection/ComparatorResultComparisonInspection.java @@ -78,7 +78,7 @@ public class ComparatorResultComparisonInspection extends BaseJavaBatchLocalInsp if (jodaCondition) { relationType = relationType.getFlipped(); } - holder.registerProblem(sign, InspectionsBundle.message("inspection.comparator.result.comparison.display.name"), + holder.registerProblem(sign, InspectionsBundle.message("inspection.comparator.result.comparison.problem.display.name"), new ComparatorComparisonFix(jodaCondition, relationType)); } };