From 3fc4644c53c624a3fc415361912e31b37ed7bb77 Mon Sep 17 00:00:00 2001 From: Yaroslav Pankratyev Date: Fri, 12 Oct 2018 15:44:50 +0700 Subject: [PATCH] AnnotatedElementInspectionBase javadoc and minor refactoring --- .../codeInspection/AnnotatedElementInspectionBase.java | 9 ++++++++- .../codeInspection/ScheduledForRemovalInspection.java | 5 ----- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/jvm/jvm-analysis-impl/src/com/intellij/codeInspection/AnnotatedElementInspectionBase.java b/jvm/jvm-analysis-impl/src/com/intellij/codeInspection/AnnotatedElementInspectionBase.java index 02186018302f..531ec80ea810 100644 --- a/jvm/jvm-analysis-impl/src/com/intellij/codeInspection/AnnotatedElementInspectionBase.java +++ b/jvm/jvm-analysis-impl/src/com/intellij/codeInspection/AnnotatedElementInspectionBase.java @@ -16,6 +16,11 @@ import org.jetbrains.uast.UastContextKt; import javax.swing.*; import java.util.List; +/** + * This class can be extended by inspections that should report usage of elements annotated with some particular annotation(s). + * + * @since 2018.3 + */ public abstract class AnnotatedElementInspectionBase extends LocalInspectionTool { public boolean myIgnoreInsideImports = true; @@ -25,7 +30,9 @@ public abstract class AnnotatedElementInspectionBase extends LocalInspectionTool protected abstract void createProblem(@NotNull PsiReference reference, @NotNull ProblemsHolder holder); - protected abstract boolean shouldProcessElement(@NotNull PsiModifierListOwner element); + protected boolean shouldProcessElement(@NotNull PsiModifierListOwner element) { + return true; + } @NotNull diff --git a/jvm/jvm-analysis-impl/src/com/intellij/codeInspection/ScheduledForRemovalInspection.java b/jvm/jvm-analysis-impl/src/com/intellij/codeInspection/ScheduledForRemovalInspection.java index 0097385757fb..2011e2d2ad14 100644 --- a/jvm/jvm-analysis-impl/src/com/intellij/codeInspection/ScheduledForRemovalInspection.java +++ b/jvm/jvm-analysis-impl/src/com/intellij/codeInspection/ScheduledForRemovalInspection.java @@ -24,9 +24,4 @@ public class ScheduledForRemovalInspection extends AnnotatedElementInspectionBas String message = JvmAnalysisBundle.message("jvm.inspections.scheduled.for.removal.description", getReferenceText(reference)); holder.registerProblem(reference, message, ProblemHighlightType.LIKE_MARKED_FOR_REMOVAL); } - - @Override - protected boolean shouldProcessElement(@NotNull PsiModifierListOwner element) { - return true; - } }