diff --git a/java/compiler/impl/src/com/intellij/compiler/impl/CompilerEncodingServiceImpl.java b/java/compiler/impl/src/com/intellij/compiler/impl/CompilerEncodingServiceImpl.java index 34a49096f894..462a73375d3d 100644 --- a/java/compiler/impl/src/com/intellij/compiler/impl/CompilerEncodingServiceImpl.java +++ b/java/compiler/impl/src/com/intellij/compiler/impl/CompilerEncodingServiceImpl.java @@ -1,5 +1,5 @@ /* - * Copyright 2000-2012 JetBrains s.r.o. + * Copyright 2000-2014 JetBrains s.r.o. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -60,6 +60,7 @@ public class CompilerEncodingServiceImpl extends CompilerEncodingService { }, false); } + @NotNull private Map> computeModuleCharsetMap() { final Map> map = new THashMap>(); final Map mappings = EncodingProjectManager.getInstance(myProject).getAllMappings(); diff --git a/platform/platform-impl/src/com/intellij/openapi/vfs/encoding/ChooseFileEncodingAction.java b/platform/platform-impl/src/com/intellij/openapi/vfs/encoding/ChooseFileEncodingAction.java index 9996800765e5..19d836c480a6 100644 --- a/platform/platform-impl/src/com/intellij/openapi/vfs/encoding/ChooseFileEncodingAction.java +++ b/platform/platform-impl/src/com/intellij/openapi/vfs/encoding/ChooseFileEncodingAction.java @@ -1,5 +1,5 @@ /* - * Copyright 2000-2009 JetBrains s.r.o. + * Copyright 2000-2014 JetBrains s.r.o. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -68,7 +68,7 @@ public abstract class ChooseFileEncodingAction extends ComboBoxAction { } @Override - public void update(AnActionEvent e) { + public void update(@NotNull AnActionEvent e) { } @Override @@ -89,7 +89,7 @@ public abstract class ChooseFileEncodingAction extends ComboBoxAction { } @Override - public void actionPerformed(final AnActionEvent e) { + public void actionPerformed(@NotNull final AnActionEvent e) { chosen(myFile, NO_ENCODING); } } diff --git a/platform/util/src/com/intellij/util/containers/ContainerUtil.java b/platform/util/src/com/intellij/util/containers/ContainerUtil.java index 3cb42e33ec47..8a43e245aa14 100644 --- a/platform/util/src/com/intellij/util/containers/ContainerUtil.java +++ b/platform/util/src/com/intellij/util/containers/ContainerUtil.java @@ -1426,8 +1426,8 @@ public class ContainerUtil extends ContainerUtilRt { } @Contract(pure=true) - public static T getFirstItem(@Nullable final Collection items, @Nullable final T def) { - return items == null || items.isEmpty() ? def : items.iterator().next(); + public static T getFirstItem(@Nullable final Collection items, @Nullable final T defaultResult) { + return items == null || items.isEmpty() ? defaultResult : items.iterator().next(); } /**