From 3d79b7fea6dd78817790adc67974b18b43ec276f Mon Sep 17 00:00:00 2001 From: Kirill Likhodedov Date: Thu, 16 Apr 2015 15:17:39 +0300 Subject: [PATCH] [git] interactive rebase: remove pointless statements without "return", `success` will be overwritten by false later, and it is correct when rebase is cancelled. --- .../git4idea/rebase/GitInteractiveRebaseEditorHandler.java | 4 ---- 1 file changed, 4 deletions(-) diff --git a/plugins/git4idea/src/git4idea/rebase/GitInteractiveRebaseEditorHandler.java b/plugins/git4idea/src/git4idea/rebase/GitInteractiveRebaseEditorHandler.java index c048c464ca48..0c1dba06ed74 100644 --- a/plugins/git4idea/src/git4idea/rebase/GitInteractiveRebaseEditorHandler.java +++ b/plugins/git4idea/src/git4idea/rebase/GitInteractiveRebaseEditorHandler.java @@ -113,9 +113,6 @@ public class GitInteractiveRebaseEditorHandler implements Closeable, GitRebaseEd isSuccess.set(true); return; } - else { - isSuccess.set(false); - } } else { setRebaseEditorShown(); @@ -130,7 +127,6 @@ public class GitInteractiveRebaseEditorHandler implements Closeable, GitRebaseEd } else { rebaseFile.cancel(); - isSuccess.set(true); } } catch (GitInteractiveRebaseFile.NoopException e) {