diff --git a/python/src/com/jetbrains/python/pyi/PyiVisitorFilter.java b/python/src/com/jetbrains/python/pyi/PyiVisitorFilter.java index c10b3f9167b0..fe3b2fe94587 100644 --- a/python/src/com/jetbrains/python/pyi/PyiVisitorFilter.java +++ b/python/src/com/jetbrains/python/pyi/PyiVisitorFilter.java @@ -16,9 +16,7 @@ package com.jetbrains.python.pyi; import com.intellij.psi.PsiFile; -import com.jetbrains.python.inspections.PyStatementEffectInspection; -import com.jetbrains.python.inspections.PyUnusedLocalInspection; -import com.jetbrains.python.inspections.PythonVisitorFilter; +import com.jetbrains.python.inspections.*; import org.jetbrains.annotations.NotNull; /** @@ -27,7 +25,8 @@ import org.jetbrains.annotations.NotNull; public class PyiVisitorFilter implements PythonVisitorFilter { @Override public boolean isSupported(@NotNull Class visitorClass, @NotNull PsiFile file) { - if (visitorClass == PyUnusedLocalInspection.class || visitorClass == PyStatementEffectInspection.class) { + if (visitorClass == PyUnusedLocalInspection.class || visitorClass == PyStatementEffectInspection.class || + visitorClass == PyCompatibilityInspection.class || visitorClass == PyMissingOrEmptyDocstringInspection.class) { return false; } return true; diff --git a/python/testData/pyi/inspections/pyiCompatibilityAndEllipsis/PyiCompatibilityAndEllipsis.pyi b/python/testData/pyi/inspections/pyiCompatibilityAndEllipsis/PyiCompatibilityAndEllipsis.pyi new file mode 100644 index 000000000000..b119bfd9497e --- /dev/null +++ b/python/testData/pyi/inspections/pyiCompatibilityAndEllipsis/PyiCompatibilityAndEllipsis.pyi @@ -0,0 +1 @@ +def func(x: int): ... \ No newline at end of file diff --git a/python/testData/pyi/inspections/pyiMissingOrEmptyDocstring/PyiMissingOrEmptyDocstring.pyi b/python/testData/pyi/inspections/pyiMissingOrEmptyDocstring/PyiMissingOrEmptyDocstring.pyi new file mode 100644 index 000000000000..7e6fea81ffe6 --- /dev/null +++ b/python/testData/pyi/inspections/pyiMissingOrEmptyDocstring/PyiMissingOrEmptyDocstring.pyi @@ -0,0 +1,5 @@ +def no_docstring(): ... + + +def empty_docstring(): + """""" diff --git a/python/testSrc/com/jetbrains/python/pyi/PyiInspectionsTest.java b/python/testSrc/com/jetbrains/python/pyi/PyiInspectionsTest.java index 9b465e2c961d..d417cc7782fb 100644 --- a/python/testSrc/com/jetbrains/python/pyi/PyiInspectionsTest.java +++ b/python/testSrc/com/jetbrains/python/pyi/PyiInspectionsTest.java @@ -18,9 +18,7 @@ package com.jetbrains.python.pyi; import com.intellij.codeInspection.LocalInspectionTool; import com.intellij.psi.PsiDocumentManager; import com.jetbrains.python.fixtures.PyTestCase; -import com.jetbrains.python.inspections.PyStatementEffectInspection; -import com.jetbrains.python.inspections.PyTypeCheckerInspection; -import com.jetbrains.python.inspections.PyUnusedLocalInspection; +import com.jetbrains.python.inspections.*; import com.jetbrains.python.inspections.unresolvedReference.PyUnresolvedReferencesInspection; import org.jetbrains.annotations.NotNull; @@ -65,4 +63,14 @@ public class PyiInspectionsTest extends PyTestCase { public void testPyiStatementEffect() { doPyiTest(PyStatementEffectInspection.class); } + + // PY-19375 + public void testPyiCompatibilityAndEllipsis() { + doPyiTest(PyCompatibilityInspection.class); + } + + // PY-19375 + public void testPyiMissingOrEmptyDocstring() { + doPyiTest(PyMissingOrEmptyDocstringInspection.class); + } }