From 3a8596a0e35fc04cc75a1c77411ef58531b1f108 Mon Sep 17 00:00:00 2001
From: Petr <petr.golubev@jetbrains.com>
Date: Wed, 27 Mar 2024 11:07:23 +0100
Subject: [PATCH] PY-38928 Parentheses around unpacking for "for" loop target
 variables break type inference

GitOrigin-RevId: 9debb720880dd77b47c325e426e2d76c74135192
---
 .../python/psi/impl/PyTargetExpressionImpl.java       |  5 +++--
 python/testSrc/com/jetbrains/python/PyTypeTest.java   | 11 +++++++++++
 2 files changed, 14 insertions(+), 2 deletions(-)

diff --git a/python/python-psi-impl/src/com/jetbrains/python/psi/impl/PyTargetExpressionImpl.java b/python/python-psi-impl/src/com/jetbrains/python/psi/impl/PyTargetExpressionImpl.java
index 2a1006dc2b05..c8b46df01e55 100644
--- a/python/python-psi-impl/src/com/jetbrains/python/psi/impl/PyTargetExpressionImpl.java
+++ b/python/python-psi-impl/src/com/jetbrains/python/psi/impl/PyTargetExpressionImpl.java
@@ -301,8 +301,9 @@ public class PyTargetExpressionImpl extends PyBaseElementImpl<PyTargetExpression
     if (source != null) {
       final PyType sourceType = context.getType(source);
       final PyType type = getIterationType(sourceType, source, this, context);
-      if (type instanceof PyTupleType && target instanceof PyTupleExpression) {
-        return PyTypeChecker.getTargetTypeFromTupleAssignment(this, (PyTupleExpression)target, (PyTupleType)type);
+      target = PyPsiUtils.flattenParens(target);
+      if (type instanceof PyTupleType tupleType && target instanceof PyTupleExpression tupleExpression) {
+        return PyTypeChecker.getTargetTypeFromTupleAssignment(this, tupleExpression, tupleType);
       }
       if (target == this && type != null) {
         return type;
diff --git a/python/testSrc/com/jetbrains/python/PyTypeTest.java b/python/testSrc/com/jetbrains/python/PyTypeTest.java
index 577f9e9bebac..512e2e2cb0ce 100644
--- a/python/testSrc/com/jetbrains/python/PyTypeTest.java
+++ b/python/testSrc/com/jetbrains/python/PyTypeTest.java
@@ -1114,6 +1114,17 @@ public class PyTypeTest extends PyTestCase {
            "(a, (_, expr)) = (1, xs) ");
   }
 
+  // PY-38928
+  public void testIterateListOfTuples() {
+    doTest(
+      "str",
+      """
+        for ((_, expr)) in [(1, 'foo')]:
+            pass
+        """
+    );
+  }
+
   public void testConstructorUnification() {
     doTest("C[int]",
            """