From 399fb22fa884e6465718782f557da57a95c0cbab Mon Sep 17 00:00:00 2001 From: Andrey Vokin Date: Thu, 12 Apr 2018 11:30:07 +0200 Subject: [PATCH] Open in Browser action should handle big html files with language TEXT RUBY-21357 "Open in browser" doesn't open html files exceeded size limit of 2.56M --- .../intellij/ide/browsers/impl/WebBrowserServiceImpl.kt | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/xml/impl/src/com/intellij/ide/browsers/impl/WebBrowserServiceImpl.kt b/xml/impl/src/com/intellij/ide/browsers/impl/WebBrowserServiceImpl.kt index 1d6620a44d64..4431754d9ac1 100644 --- a/xml/impl/src/com/intellij/ide/browsers/impl/WebBrowserServiceImpl.kt +++ b/xml/impl/src/com/intellij/ide/browsers/impl/WebBrowserServiceImpl.kt @@ -20,6 +20,7 @@ import com.intellij.ide.browsers.WebBrowserService import com.intellij.ide.browsers.WebBrowserUrlProvider import com.intellij.ide.browsers.createOpenInBrowserRequest import com.intellij.lang.xml.XMLLanguage +import com.intellij.openapi.fileTypes.LanguageFileType import com.intellij.openapi.project.DumbService import com.intellij.psi.PsiElement import com.intellij.testFramework.LightVirtualFile @@ -62,7 +63,11 @@ class WebBrowserServiceImpl : WebBrowserService() { } override fun getUrlsToOpen(request: OpenInBrowserRequest, preferLocalUrl: Boolean): Collection { - val isHtmlOrXml = WebBrowserService.isHtmlOrXmlFile(request.file.viewProvider.baseLanguage) + var isHtmlOrXml = WebBrowserService.isHtmlOrXmlFile(request.file.viewProvider.baseLanguage) + if (!isHtmlOrXml && request.file.fileType is LanguageFileType) { + isHtmlOrXml = WebBrowserService.isHtmlOrXmlFile((request.file.fileType as LanguageFileType).language) + } + if (!preferLocalUrl || !isHtmlOrXml) { val dumbService = DumbService.getInstance(request.project) for (urlProvider in WebBrowserUrlProvider.EP_NAME.extensions) {