From 39068f3f87bb61197d0f5afd650a096e3bbca297 Mon Sep 17 00:00:00 2001 From: "Artem.Bukhonov" Date: Thu, 19 Jun 2025 21:27:44 +0200 Subject: [PATCH] [MCP Server] Fix tests according to the new format (cherry picked from commit 96f2e6a0797f356d3abd6779cce3522f060a5d88) GitOrigin-RevId: 5b600eb143788feca739030c80b4c1e8baf2ec60 --- .../impl/ReflectionCallableMcpTool.kt | 1 + .../com/intellij/mcpserver/InputSchemaTest.kt | 22 ++++--------------- .../mcpserver/ReturnValueRenderingTest.kt | 4 ++-- 3 files changed, 7 insertions(+), 20 deletions(-) diff --git a/plugins/mcp-server/src/com/intellij/mcpserver/impl/ReflectionCallableMcpTool.kt b/plugins/mcp-server/src/com/intellij/mcpserver/impl/ReflectionCallableMcpTool.kt index 8754e64071fb..7cd38959c51b 100644 --- a/plugins/mcp-server/src/com/intellij/mcpserver/impl/ReflectionCallableMcpTool.kt +++ b/plugins/mcp-server/src/com/intellij/mcpserver/impl/ReflectionCallableMcpTool.kt @@ -14,6 +14,7 @@ class ReflectionCallableMcpTool(override val descriptor: McpToolDescriptor, priv return when { result.result == null -> McpToolCallResult.text("[null]") result.result is Unit -> McpToolCallResult.text("[success]") + result.result is Char -> McpToolCallResult.text("'${result.result}'") // special case for String to avoid extra quotes added by Any?.toString() result.result is String -> McpToolCallResult.text(result.result) // special case for String to avoid extra quotes added by Any?.toString() result.result.javaClass.isPrimitive -> McpToolCallResult.text(result.result.toString()) result.result is McpToolCallResult -> result.result diff --git a/plugins/mcp-server/test/com/intellij/mcpserver/InputSchemaTest.kt b/plugins/mcp-server/test/com/intellij/mcpserver/InputSchemaTest.kt index bbd7d9deb514..f126cf123aab 100644 --- a/plugins/mcp-server/test/com/intellij/mcpserver/InputSchemaTest.kt +++ b/plugins/mcp-server/test/com/intellij/mcpserver/InputSchemaTest.kt @@ -82,8 +82,6 @@ class InputSchemaTest { "properties": { "intArg": { "type": "integer", - "minimum": -2147483648, - "maximum": 2147483647, "description": "int description on parameter" } }, @@ -137,8 +135,6 @@ class InputSchemaTest { "properties": { "a": { "type": "integer", - "minimum": -2147483648, - "maximum": 2147483647, "description": "Field description a" }, "b": { @@ -166,9 +162,7 @@ class InputSchemaTest { ], "properties": { "e": { - "type": "number", - "minimum": 4.9E-324, - "maximum": 1.7976931348623157E308 + "type": "number" } }, "description": "Field description d" @@ -180,9 +174,7 @@ class InputSchemaTest { ], "properties": { "e": { - "type": "number", - "minimum": 4.9E-324, - "maximum": 1.7976931348623157E308 + "type": "number" } }, "description": "Field description dOptional" @@ -211,8 +203,6 @@ class InputSchemaTest { "properties": { "a": { "type": "integer", - "minimum": -2147483648, - "maximum": 2147483647, "description": "Field description a" }, "b": { @@ -240,9 +230,7 @@ class InputSchemaTest { ], "properties": { "e": { - "type": "number", - "minimum": 4.9E-324, - "maximum": 1.7976931348623157E308 + "type": "number" } }, "description": "Field description d" @@ -254,9 +242,7 @@ class InputSchemaTest { ], "properties": { "e": { - "type": "number", - "minimum": 4.9E-324, - "maximum": 1.7976931348623157E308 + "type": "number" } }, "description": "Field description dOptional" diff --git a/plugins/mcp-server/test/com/intellij/mcpserver/ReturnValueRenderingTest.kt b/plugins/mcp-server/test/com/intellij/mcpserver/ReturnValueRenderingTest.kt index d2021d7f7309..4cb5eba0e42a 100644 --- a/plugins/mcp-server/test/com/intellij/mcpserver/ReturnValueRenderingTest.kt +++ b/plugins/mcp-server/test/com/intellij/mcpserver/ReturnValueRenderingTest.kt @@ -33,8 +33,8 @@ class ReturnValueRenderingTest { Arguments.of(::returnShort,"12345"), Arguments.of(::returnByte,"123"), Arguments.of(::returnBoolean,"true"), - Arguments.of(::returnChar,"\"a\""), - Arguments.of(::returnString,"\"string\""), + Arguments.of(::returnChar,"'a'"), + Arguments.of(::returnString,"string"), Arguments.of(::returnFloat,"1.23458"), Arguments.of(::returnDouble,"1.2345"), Arguments.of(::returnVoid,"[success]"),