diff --git a/platform/lang-impl/src/com/intellij/cyclicDependencies/CyclicGraphUtil.java b/platform/lang-impl/src/com/intellij/cyclicDependencies/CyclicGraphUtil.java index 2fd9fc02d108..7c8cc6790382 100644 --- a/platform/lang-impl/src/com/intellij/cyclicDependencies/CyclicGraphUtil.java +++ b/platform/lang-impl/src/com/intellij/cyclicDependencies/CyclicGraphUtil.java @@ -9,6 +9,9 @@ import java.util.*; * Date: Feb 13, 2005 */ public class CyclicGraphUtil { + private CyclicGraphUtil() { + } + public static Set> getNodeCycles(final Graph graph, final Node node){ Set> result = new HashSet>(); @@ -55,8 +58,7 @@ public class CyclicGraphUtil { final HashSet retainNodes = new HashSet(inNodes); retainNodes.retainAll(outNodes); - for (Iterator iterator = retainNodes.iterator(); iterator.hasNext();) { - Node node1 = iterator.next(); + for (Node node1 : retainNodes) { ArrayList oneNodeCycle = new ArrayList(); oneNodeCycle.add(node1); oneNodeCycle.add(node); @@ -66,14 +68,12 @@ public class CyclicGraphUtil { inNodes.removeAll(retainNodes); outNodes.removeAll(retainNodes); - final ShortestPathUtil algorithm = new ShortestPathUtil(graphWithoutNode); + final ShortestPathUtil algorithm = new ShortestPathUtil(graphWithoutNode); - for (Iterator iterator = outNodes.iterator(); iterator.hasNext();) { - Node fromNode = iterator.next(); - for (Iterator iterator1 = inNodes.iterator(); iterator1.hasNext();) { - Node toNode = iterator1.next(); - final List shortestPath = algorithm.getShortestPath( toNode, fromNode); - if (shortestPath != null){ + for (Node fromNode : outNodes) { + for (Node toNode : inNodes) { + final List shortestPath = algorithm.getShortestPath(toNode, fromNode); + if (shortestPath != null) { ArrayList path = new ArrayList(); path.addAll(shortestPath); path.add(node); diff --git a/idea-tests/src/com/intellij/dependencies/SearchCyclesTest.java b/platform/lang-impl/testSrc/com/intellij/dependencies/SearchCyclesTest.java similarity index 96% rename from idea-tests/src/com/intellij/dependencies/SearchCyclesTest.java rename to platform/lang-impl/testSrc/com/intellij/dependencies/SearchCyclesTest.java index c93b2064eac1..6f876e13868f 100644 --- a/idea-tests/src/com/intellij/dependencies/SearchCyclesTest.java +++ b/platform/lang-impl/testSrc/com/intellij/dependencies/SearchCyclesTest.java @@ -132,10 +132,9 @@ public class SearchCyclesTest extends TestCase{ checkResult(new String[][]{{"b","d","e","c","a"}, {"e","c","a"}}, nodeCycles); } - private void checkResult(String[][] expected, Set> cycles){ + private static void checkResult(String[][] expected, Set> cycles){ assertEquals(expected.length, cycles.size()); - for (Iterator> iterator = cycles.iterator(); iterator.hasNext();) { - List strings = iterator.next(); + for (List strings : cycles) { assertTrue(findInMatrix(expected, strings.toArray(new String[strings.size()])) > -1); } }