From 3614b742bbd44e2b0c36eece3c350b9c9056edf6 Mon Sep 17 00:00:00 2001 From: Tagir Valeev Date: Thu, 14 Dec 2023 11:31:40 +0100 Subject: [PATCH] final method in final class warning fixed GitOrigin-RevId: eeec0047e89c8bcd9768022405964716ac0bb75e --- .../MisorderedAssertEqualsArgumentsInspection.java | 6 +++--- .../intellij/refactoring/rename/RenameWrongRefHandler.java | 2 +- .../ReplaceConstructorWithBuilderAction.java | 2 +- .../intention/ReplaceConstructorWithFactoryAction.java | 2 +- .../codeInsight/intention/impl/EncapsulateFieldAction.java | 2 +- .../ipp/annotation/AnnotateOverriddenMethodsIntention.java | 4 ++-- .../src/com/jetbrains/python/psi/impl/PyPsiFacadeImpl.java | 2 +- 7 files changed, 10 insertions(+), 10 deletions(-) diff --git a/java/java-analysis-impl/src/com/siyeh/ig/testFrameworks/MisorderedAssertEqualsArgumentsInspection.java b/java/java-analysis-impl/src/com/siyeh/ig/testFrameworks/MisorderedAssertEqualsArgumentsInspection.java index a7e40c230ae2..a604e5358bdc 100644 --- a/java/java-analysis-impl/src/com/siyeh/ig/testFrameworks/MisorderedAssertEqualsArgumentsInspection.java +++ b/java/java-analysis-impl/src/com/siyeh/ig/testFrameworks/MisorderedAssertEqualsArgumentsInspection.java @@ -34,12 +34,12 @@ public final class MisorderedAssertEqualsArgumentsInspection extends BaseInspect @Override @NotNull - protected final String buildErrorString(Object... infos) { + protected String buildErrorString(Object... infos) { return InspectionGadgetsBundle.message("misordered.assert.equals.arguments.problem.descriptor"); } @Override - public final LocalQuickFix buildFix(Object... infos) { + public LocalQuickFix buildFix(Object... infos) { return new FlipArgumentsFix(); } @@ -149,7 +149,7 @@ public final class MisorderedAssertEqualsArgumentsInspection extends BaseInspect } @Override - public final BaseInspectionVisitor buildVisitor() { + public BaseInspectionVisitor buildVisitor() { return new MisorderedAssertEqualsParametersVisitor(); } diff --git a/java/java-impl-refactorings/src/com/intellij/refactoring/rename/RenameWrongRefHandler.java b/java/java-impl-refactorings/src/com/intellij/refactoring/rename/RenameWrongRefHandler.java index 81480c898579..a3cca27e201a 100644 --- a/java/java-impl-refactorings/src/com/intellij/refactoring/rename/RenameWrongRefHandler.java +++ b/java/java-impl-refactorings/src/com/intellij/refactoring/rename/RenameWrongRefHandler.java @@ -18,7 +18,7 @@ public final class RenameWrongRefHandler implements RenameHandler { @Override - public final boolean isAvailableOnDataContext(@NotNull final DataContext dataContext) { + public boolean isAvailableOnDataContext(@NotNull final DataContext dataContext) { final Editor editor = CommonDataKeys.EDITOR.getData(dataContext); final PsiFile file = CommonDataKeys.PSI_FILE.getData(dataContext); final Project project = CommonDataKeys.PROJECT.getData(dataContext); diff --git a/java/java-impl-refactorings/src/com/intellij/refactoring/replaceConstructorWithBuilder/ReplaceConstructorWithBuilderAction.java b/java/java-impl-refactorings/src/com/intellij/refactoring/replaceConstructorWithBuilder/ReplaceConstructorWithBuilderAction.java index 5f1a65af8dd8..47b6e70e470b 100644 --- a/java/java-impl-refactorings/src/com/intellij/refactoring/replaceConstructorWithBuilder/ReplaceConstructorWithBuilderAction.java +++ b/java/java-impl-refactorings/src/com/intellij/refactoring/replaceConstructorWithBuilder/ReplaceConstructorWithBuilderAction.java @@ -29,7 +29,7 @@ public final class ReplaceConstructorWithBuilderAction extends PsiElementBaseInt @NotNull @Override - public final String getFamilyName() { + public String getFamilyName() { return getText(); } diff --git a/java/java-impl/src/com/intellij/codeInsight/intention/ReplaceConstructorWithFactoryAction.java b/java/java-impl/src/com/intellij/codeInsight/intention/ReplaceConstructorWithFactoryAction.java index cfc771303366..6bab3b0a9924 100644 --- a/java/java-impl/src/com/intellij/codeInsight/intention/ReplaceConstructorWithFactoryAction.java +++ b/java/java-impl/src/com/intellij/codeInsight/intention/ReplaceConstructorWithFactoryAction.java @@ -32,7 +32,7 @@ import java.util.*; public final class ReplaceConstructorWithFactoryAction implements ModCommandAction { @NotNull @Override - public final String getFamilyName() { + public String getFamilyName() { return JavaRefactoringBundle.message("replace.constructor.with.factory.method"); } diff --git a/java/java-impl/src/com/intellij/codeInsight/intention/impl/EncapsulateFieldAction.java b/java/java-impl/src/com/intellij/codeInsight/intention/impl/EncapsulateFieldAction.java index 1815d917bff0..a61f9f9dc352 100644 --- a/java/java-impl/src/com/intellij/codeInsight/intention/impl/EncapsulateFieldAction.java +++ b/java/java-impl/src/com/intellij/codeInsight/intention/impl/EncapsulateFieldAction.java @@ -25,7 +25,7 @@ public final class EncapsulateFieldAction extends BaseRefactoringIntentionAction @NotNull @Override - public final String getFamilyName() { + public String getFamilyName() { return getText(); } diff --git a/java/java-impl/src/com/siyeh/ipp/annotation/AnnotateOverriddenMethodsIntention.java b/java/java-impl/src/com/siyeh/ipp/annotation/AnnotateOverriddenMethodsIntention.java index 5f15d2bf6ac9..a58dc832a4ab 100644 --- a/java/java-impl/src/com/siyeh/ipp/annotation/AnnotateOverriddenMethodsIntention.java +++ b/java/java-impl/src/com/siyeh/ipp/annotation/AnnotateOverriddenMethodsIntention.java @@ -38,7 +38,7 @@ public final class AnnotateOverriddenMethodsIntention extends BaseElementAtCaret @NotNull @Override - public final String getText() { + public String getText() { return m_text == null ? "" : m_text; } @@ -62,7 +62,7 @@ public final class AnnotateOverriddenMethodsIntention extends BaseElementAtCaret } @Override - public final boolean isAvailable(@NotNull Project project, @NotNull Editor editor, @NotNull PsiElement node) { + public boolean isAvailable(@NotNull Project project, @NotNull Editor editor, @NotNull PsiElement node) { final PsiAnnotation annotation = (PsiAnnotation)findMatchingElement(node); if (annotation == null) return false; final String annotationText = annotation.getText(); diff --git a/python/python-psi-impl/src/com/jetbrains/python/psi/impl/PyPsiFacadeImpl.java b/python/python-psi-impl/src/com/jetbrains/python/psi/impl/PyPsiFacadeImpl.java index 6eea7e7bb601..07ee4cd62272 100644 --- a/python/python-psi-impl/src/com/jetbrains/python/psi/impl/PyPsiFacadeImpl.java +++ b/python/python-psi-impl/src/com/jetbrains/python/psi/impl/PyPsiFacadeImpl.java @@ -87,7 +87,7 @@ public final class PyPsiFacadeImpl extends PyPsiFacade { @Nullable @Override - public final PyClass createClassByQName(@NotNull final String qName, @NotNull final PsiElement anchor) { + public PyClass createClassByQName(@NotNull final String qName, @NotNull final PsiElement anchor) { final QualifiedName qualifiedName = QualifiedName.fromDottedString(qName); // Only built-in classes can be found by their unqualified names. if (qualifiedName.getComponentCount() == 1) {