From 35c14d49198e05da3fd7a9003fd9974b1d3a95df Mon Sep 17 00:00:00 2001 From: Alexander Koshevoy Date: Mon, 2 Jul 2018 14:23:47 +0300 Subject: [PATCH] PY-18029 Rename MultiplexedSocketReader methods Rename MultiplexedSocketReader methods to depict their logic more accurately. --- python/helpers/pydev/pydev_console/thrift_transport.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/python/helpers/pydev/pydev_console/thrift_transport.py b/python/helpers/pydev/pydev_console/thrift_transport.py index 472c13afb33b..e82b44f156aa 100644 --- a/python/helpers/pydev/pydev_console/thrift_transport.py +++ b/python/helpers/pydev/pydev_console/thrift_transport.py @@ -3,9 +3,9 @@ import struct import sys import threading -from pydev_console.io import PipeIO from _jetbrains_thriftpy.thrift import TClient from _jetbrains_thriftpy.transport import TTransportBase, readall +from pydev_console.io import PipeIO REQUEST = 0 RESPONSE = 1 @@ -33,7 +33,7 @@ class MultiplexedSocketReader(object): """ return self._response_pipe.read(sz) - def _try_fill_buffer(self): + def _read_and_dispatch_next_frame(self): with self._read_socket_lock: direction, frame = self._read_frame() @@ -56,12 +56,12 @@ class MultiplexedSocketReader(object): return direction, frame def start_reading(self): - t = threading.Thread(target=self._reading) + t = threading.Thread(target=self._read_forever) t.start() - def _reading(self): + def _read_forever(self): while True: - self._try_fill_buffer() + self._read_and_dispatch_next_frame() class SocketWriter(object):