From 324189dcdbebdfb72c18094e6b9ead376f9c362c Mon Sep 17 00:00:00 2001 From: Tagir Valeev Date: Thu, 14 Nov 2024 11:11:11 +0100 Subject: [PATCH] [java-inspections] SuspiciousNameCombinationInspection: exclude toUnsigned* methods Fixes IDEA-360817 False-positive "suspicious variable/parameter name combination" (cherry picked from commit 6e02686d5896a587335e1d03ce1480f9052024e5) IJ-CR-149352 GitOrigin-RevId: 611319ae06390019d5e9e79ee81697db266c815b --- .../SuspiciousNameCombinationInspection.java | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/java/java-impl-inspections/src/com/intellij/codeInspection/suspiciousNameCombination/SuspiciousNameCombinationInspection.java b/java/java-impl-inspections/src/com/intellij/codeInspection/suspiciousNameCombination/SuspiciousNameCombinationInspection.java index ea0fd5f0dc2a..e83b45759372 100644 --- a/java/java-impl-inspections/src/com/intellij/codeInspection/suspiciousNameCombination/SuspiciousNameCombinationInspection.java +++ b/java/java-impl-inspections/src/com/intellij/codeInspection/suspiciousNameCombination/SuspiciousNameCombinationInspection.java @@ -8,7 +8,6 @@ import com.intellij.codeInspection.AbstractBaseJavaLocalInspectionTool; import com.intellij.codeInspection.InspectionsBundle; import com.intellij.codeInspection.ProblemsHolder; import com.intellij.codeInspection.options.OptPane; -import com.intellij.codeInspection.options.OptionController; import com.intellij.java.JavaBundle; import com.intellij.openapi.util.InvalidDataException; import com.intellij.openapi.util.WriteExternalException; @@ -43,10 +42,10 @@ public final class SuspiciousNameCombinationInspection extends AbstractBaseJavaL .add("java.sql.ResultSet", "update.*") .add("java.sql.SQLOutput", "write.*") // parameters for compare methods are x and y which is also unrelated to coordinates - .add("java.lang.Integer", "compare.*") + .add("java.lang.Integer", "compare.*|toUnsignedLong") .add("java.lang.Long", "compare.*") - .add("java.lang.Short", "compare") - .add("java.lang.Byte", "compare") + .add("java.lang.Short", "compare|toUnsigned.*") + .add("java.lang.Byte", "compare|toUnsigned.*") .add("java.lang.Character", "compare") .add("java.lang.Boolean", "compare") // parameter names for addExact, multiplyFull, floorDiv, hypot etc. are x and y,