From 307f921fb8bc4c92040258bf901012b1a4e8f08e Mon Sep 17 00:00:00 2001 From: Bas Leijdekkers Date: Sat, 7 Sep 2013 12:01:19 +0200 Subject: [PATCH] IDEA-53184 (False positive unused field inspection for serialVersionUID fields) --- .../codeInsight/daemon/impl/PostHighlightingPass.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/java/java-impl/src/com/intellij/codeInsight/daemon/impl/PostHighlightingPass.java b/java/java-impl/src/com/intellij/codeInsight/daemon/impl/PostHighlightingPass.java index 97629fbaff71..446a1f1662af 100644 --- a/java/java-impl/src/com/intellij/codeInsight/daemon/impl/PostHighlightingPass.java +++ b/java/java-impl/src/com/intellij/codeInsight/daemon/impl/PostHighlightingPass.java @@ -407,11 +407,11 @@ public class PostHighlightingPass extends TextEditorHighlightingPass { @NotNull PsiIdentifier identifier, @NotNull ProgressIndicator progress, @NotNull GlobalUsageHelper helper) { + if (HighlightUtil.isSerializationImplicitlyUsedField(field)) { + return null; + } if (field.hasModifierProperty(PsiModifier.PRIVATE)) { if (!myRefCountHolder.isReferenced(field) && !isImplicitUsage(field, progress)) { - if (HighlightUtil.isSerializationImplicitlyUsedField(field)) { - return null; - } String message = JavaErrorMessages.message("private.field.is.not.used", identifier.getText()); HighlightInfo highlightInfo = suggestionsToMakeFieldUsed(field, identifier, message);