From 2fa78de9fb5d2b227416435bc0603f8a98c5cb51 Mon Sep 17 00:00:00 2001 From: peter Date: Tue, 20 Mar 2012 18:25:27 +0100 Subject: [PATCH] more info on EA-34347 --- .../com/intellij/codeInsight/lookup/impl/LookupImpl.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/platform/lang-impl/src/com/intellij/codeInsight/lookup/impl/LookupImpl.java b/platform/lang-impl/src/com/intellij/codeInsight/lookup/impl/LookupImpl.java index 9d2c76e76879..978dbe22d15d 100644 --- a/platform/lang-impl/src/com/intellij/codeInsight/lookup/impl/LookupImpl.java +++ b/platform/lang-impl/src/com/intellij/codeInsight/lookup/impl/LookupImpl.java @@ -890,8 +890,9 @@ public class LookupImpl extends LightweightHint implements LookupEx, Disposable public boolean performGuardedChange(Runnable change, @Nullable final String debug) { checkValid(); - assert myLookupStartMarker.isValid(); - assert !myChangeGuard; + assert myLookupStartMarker != null : "null start before"; + assert myLookupStartMarker.isValid() : "invalid start"; + assert !myChangeGuard : "already in change"; myChangeGuard = true; final Document document = myEditor.getDocument(); @@ -911,7 +912,7 @@ public class LookupImpl extends LightweightHint implements LookupEx, Disposable document.removeDocumentListener(spy); myChangeGuard = false; } - if (!myLookupStartMarker.isValid() || myDisposed) { + if (myDisposed || !myLookupStartMarker.isValid()) { hide(); return false; }