From 2efaf7375b82c4c561570ecd500a68d56f84e9ed Mon Sep 17 00:00:00 2001 From: Andrey Vlasovskikh Date: Mon, 14 Oct 2013 15:46:38 +0200 Subject: [PATCH] Extracted name of str.format() function --- python/psi-api/src/com/jetbrains/python/PyNames.java | 2 ++ .../com/jetbrains/python/inspections/PyStringFormatParser.java | 3 ++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/python/psi-api/src/com/jetbrains/python/PyNames.java b/python/psi-api/src/com/jetbrains/python/PyNames.java index ca7bdadd22ff..c87f04baf95b 100644 --- a/python/psi-api/src/com/jetbrains/python/PyNames.java +++ b/python/psi-api/src/com/jetbrains/python/PyNames.java @@ -119,6 +119,8 @@ public class PyNames { public static final String COLLECTIONS = "collections"; public static final String COLLECTIONS_NAMEDTUPLE = COLLECTIONS + "." + NAMEDTUPLE; + public static final String FORMAT = "format"; + public static final String ABSTRACTMETHOD = "abstractmethod"; public static final String ABSTRACTPROPERTY = "abstractproperty"; diff --git a/python/src/com/jetbrains/python/inspections/PyStringFormatParser.java b/python/src/com/jetbrains/python/inspections/PyStringFormatParser.java index 650520650364..19743668adf6 100644 --- a/python/src/com/jetbrains/python/inspections/PyStringFormatParser.java +++ b/python/src/com/jetbrains/python/inspections/PyStringFormatParser.java @@ -4,6 +4,7 @@ import com.intellij.openapi.util.TextRange; import com.intellij.openapi.util.text.StringUtil; import com.intellij.psi.PsiElement; import com.intellij.util.containers.HashMap; +import com.jetbrains.python.PyNames; import com.jetbrains.python.psi.*; import com.jetbrains.python.psi.impl.PyStringLiteralExpressionImpl; import org.jetbrains.annotations.NotNull; @@ -358,7 +359,7 @@ public class PyStringFormatParser { if (parent instanceof PyQualifiedExpression) { final PyQualifiedExpression qualifiedExpr = (PyQualifiedExpression)parent; final String name = qualifiedExpr.getReferencedName(); - if ("format".equals(name)) { + if (PyNames.FORMAT.equals(name)) { final PsiElement parent2 = qualifiedExpr.getParent(); if (parent2 instanceof PyCallExpression) { final PyCallExpression callExpr = (PyCallExpression)parent2;