From 2bcb8887e0d9c427d2d49d63d5343e66476f7b8d Mon Sep 17 00:00:00 2001
From: peter <peter@jetbrains.com>
Date: Fri, 26 Feb 2016 14:50:25 +0100
Subject: [PATCH] correct javadoc qualified class name completion
 (IDEA-CR-8279)

---
 .../completion/JavaClassNameInsertHandler.java         | 10 +++-------
 .../completion/JavadocCompletionTest.groovy            |  2 +-
 2 files changed, 4 insertions(+), 8 deletions(-)

diff --git a/java/java-impl/src/com/intellij/codeInsight/completion/JavaClassNameInsertHandler.java b/java/java-impl/src/com/intellij/codeInsight/completion/JavaClassNameInsertHandler.java
index 677aa3b5eaab..1a674347b592 100644
--- a/java/java-impl/src/com/intellij/codeInsight/completion/JavaClassNameInsertHandler.java
+++ b/java/java-impl/src/com/intellij/codeInsight/completion/JavaClassNameInsertHandler.java
@@ -72,8 +72,9 @@ class JavaClassNameInsertHandler implements InsertHandler<JavaPsiClassReferenceE
       AutoPopupController.getInstance(context.getProject()).autoPopupMemberLookup(context.getEditor(), null);
     }
 
-    if (PsiTreeUtil.getParentOfType(position, PsiDocComment.class, false) != null && shouldInsertFqnInJavadoc(item, file, project)) {
-      context.getDocument().replaceString(context.getStartOffset(), context.getTailOffset(), getJavadocQualifiedName(psiClass));
+    String qname = psiClass.getQualifiedName();
+    if (qname != null && PsiTreeUtil.getParentOfType(position, PsiDocComment.class, false) != null && shouldInsertFqnInJavadoc(item, file, project)) {
+      context.getDocument().replaceString(context.getStartOffset(), context.getTailOffset(), qname);
       return;
     }
 
@@ -122,11 +123,6 @@ class JavaClassNameInsertHandler implements InsertHandler<JavaPsiClassReferenceE
     }
   }
 
-  private static String getJavadocQualifiedName(PsiClass psiClass) {
-    PsiClass containingClass = psiClass.getContainingClass();
-    return containingClass != null ? getJavadocQualifiedName(containingClass) + "#" + psiClass.getName() : psiClass.getQualifiedName();
-  }
-
   private static boolean shouldInsertFqnInJavadoc(@NotNull JavaPsiClassReferenceElement item,
                                                   @NotNull PsiFile file,
                                                   @NotNull Project project) 
diff --git a/java/java-tests/testSrc/com/intellij/codeInsight/completion/JavadocCompletionTest.groovy b/java/java-tests/testSrc/com/intellij/codeInsight/completion/JavadocCompletionTest.groovy
index 6c841f335b29..ffc9a03f8c06 100644
--- a/java/java-tests/testSrc/com/intellij/codeInsight/completion/JavadocCompletionTest.groovy
+++ b/java/java-tests/testSrc/com/intellij/codeInsight/completion/JavadocCompletionTest.groovy
@@ -600,7 +600,7 @@ class Foo {
     myFixture.addClass('package zoo; public class Outer { public static class FooBarGoo{}}')
     myFixture.configureByText 'a.java', "/** FooBarGo<caret> */"
     myFixture.completeBasic()
-    myFixture.checkResult "/** {@link zoo.Outer#FooBarGoo<caret>} */"
+    myFixture.checkResult "/** {@link zoo.Outer.FooBarGoo<caret>} */"
   }
 
   public void "test insert link to imported class"() {