From 2b65e4e0c79c5db33c8f0a159bfb459c87ae3aa6 Mon Sep 17 00:00:00 2001 From: Nikita Bobko Date: Tue, 30 May 2023 12:59:30 +0200 Subject: [PATCH] fixup! Improve remove.use.site.get.target wording GitOrigin-RevId: 298e085889e8414432d7cf721ad79898f8a01d58 --- .../resources/resources-en/messages/KotlinBundle.properties | 4 ++-- .../removeAnnotation/useSiteGetDoesntHaveAnyEffect.kt | 2 +- .../removeAnnotation/useSiteGetDoesntHaveAnyEffect.kt.after | 2 +- .../testData/quickfix/removeAnnotation/useSiteGetOnClass.kt | 2 +- .../quickfix/removeUseSiteTarget/setTargetOnGetter.kt | 2 +- .../removeUseSiteTarget/useSiteGetDoesntHaveAnyEffect.kt | 2 +- .../useSiteGetDoesntHaveAnyEffect.kt.after | 2 +- .../quickfix/removeUseSiteTarget/useSiteGetOnClass.kt | 2 +- .../testData/quickfix/removeUseSiteTarget/whitespaces.kt | 2 +- .../quickfix/removeUseSiteTarget/whitespaces.kt.after | 2 +- 10 files changed, 11 insertions(+), 11 deletions(-) diff --git a/plugins/kotlin/base/resources/resources-en/messages/KotlinBundle.properties b/plugins/kotlin/base/resources/resources-en/messages/KotlinBundle.properties index 59c22575c2b3..c204ab904f54 100644 --- a/plugins/kotlin/base/resources/resources-en/messages/KotlinBundle.properties +++ b/plugins/kotlin/base/resources/resources-en/messages/KotlinBundle.properties @@ -1508,8 +1508,8 @@ remove.redundant.with.fix.text=Remove redundant 'with' call remove.jvmoverloads.annotation=Remove @JvmOverloads annotation remove.jvmfield.annotation=Remove @JvmField annotation remove.extension.function.type.annotation=Remove inapplicable @ExtensionFunctionType annotation -remove.annotation.doesnt.have.any.effect=Remove annotation, since it doesn't have any effect. See https://youtrack.jetbrains.com/issue/KT-48141 -remove.use.site.get.target=Remove 'get:' target to make the annotation effective (changes semantics, see: https://youtrack.jetbrains.com/issue/KT-48141) +remove.annotation.doesnt.have.any.effect=Remove annotation, since it has no effect. See: https://youtrack.jetbrains.com/issue/KT-48141 +remove.use.site.get.target=Remove 'get:' to make the annotation effective. (changes semantics. See: https://youtrack.jetbrains.com/issue/KT-48141) report.also.for.a.variables.without.a.whitespace.around=Report also for a variables without a whitespace around remove.curly.braces=Remove curly braces redundant.curly.braces.in.string.template=Redundant curly braces in string template diff --git a/plugins/kotlin/idea/tests/testData/quickfix/removeAnnotation/useSiteGetDoesntHaveAnyEffect.kt b/plugins/kotlin/idea/tests/testData/quickfix/removeAnnotation/useSiteGetDoesntHaveAnyEffect.kt index c29d41bd0e12..10bbe28920b6 100644 --- a/plugins/kotlin/idea/tests/testData/quickfix/removeAnnotation/useSiteGetDoesntHaveAnyEffect.kt +++ b/plugins/kotlin/idea/tests/testData/quickfix/removeAnnotation/useSiteGetDoesntHaveAnyEffect.kt @@ -1,4 +1,4 @@ -// "Remove annotation, since it doesn't have any effect. See https://youtrack.jetbrains.com/issue/KT-48141" "true" +// "Remove annotation, since it has no effect. See: https://youtrack.jetbrains.com/issue/KT-48141" "true" // WITH_STDLIB class Foo { private val bar = 0 diff --git a/plugins/kotlin/idea/tests/testData/quickfix/removeAnnotation/useSiteGetDoesntHaveAnyEffect.kt.after b/plugins/kotlin/idea/tests/testData/quickfix/removeAnnotation/useSiteGetDoesntHaveAnyEffect.kt.after index 14f8df37f946..8a971e296746 100644 --- a/plugins/kotlin/idea/tests/testData/quickfix/removeAnnotation/useSiteGetDoesntHaveAnyEffect.kt.after +++ b/plugins/kotlin/idea/tests/testData/quickfix/removeAnnotation/useSiteGetDoesntHaveAnyEffect.kt.after @@ -1,4 +1,4 @@ -// "Remove annotation, since it doesn't have any effect. See https://youtrack.jetbrains.com/issue/KT-48141" "true" +// "Remove annotation, since it has no effect. See: https://youtrack.jetbrains.com/issue/KT-48141" "true" // WITH_STDLIB class Foo { private val bar = 0 diff --git a/plugins/kotlin/idea/tests/testData/quickfix/removeAnnotation/useSiteGetOnClass.kt b/plugins/kotlin/idea/tests/testData/quickfix/removeAnnotation/useSiteGetOnClass.kt index 6615ab733180..f49aa8ffaeb3 100644 --- a/plugins/kotlin/idea/tests/testData/quickfix/removeAnnotation/useSiteGetOnClass.kt +++ b/plugins/kotlin/idea/tests/testData/quickfix/removeAnnotation/useSiteGetOnClass.kt @@ -1,4 +1,4 @@ -// "Remove annotation, since it doesn't have any effect. See https://youtrack.jetbrains.com/issue/KT-48141" "false" +// "Remove annotation, since it has no effect. See https://youtrack.jetbrains.com/issue/KT-48141" "false" // IGNORE_FIR // ACTION: Create test // ACTION: Make internal diff --git a/plugins/kotlin/idea/tests/testData/quickfix/removeUseSiteTarget/setTargetOnGetter.kt b/plugins/kotlin/idea/tests/testData/quickfix/removeUseSiteTarget/setTargetOnGetter.kt index c6fbf3efdfa8..63fe24b3db58 100644 --- a/plugins/kotlin/idea/tests/testData/quickfix/removeUseSiteTarget/setTargetOnGetter.kt +++ b/plugins/kotlin/idea/tests/testData/quickfix/removeUseSiteTarget/setTargetOnGetter.kt @@ -1,4 +1,4 @@ -// "Remove 'get:' target to make the annotation effective (changes semantics, see: https://youtrack.jetbrains.com/issue/KT-48141)" "false" +// "Remove 'get:' to make the annotation effective. (changes semantics. See: https://youtrack.jetbrains.com/issue/KT-48141)" "false" // ERROR: '@set:' annotations could be applied only to property declarations // ERROR: This annotation is not applicable to target 'getter' and use site target '@set' // WITH_STDLIB diff --git a/plugins/kotlin/idea/tests/testData/quickfix/removeUseSiteTarget/useSiteGetDoesntHaveAnyEffect.kt b/plugins/kotlin/idea/tests/testData/quickfix/removeUseSiteTarget/useSiteGetDoesntHaveAnyEffect.kt index 96008d933cac..778d8de3c6aa 100644 --- a/plugins/kotlin/idea/tests/testData/quickfix/removeUseSiteTarget/useSiteGetDoesntHaveAnyEffect.kt +++ b/plugins/kotlin/idea/tests/testData/quickfix/removeUseSiteTarget/useSiteGetDoesntHaveAnyEffect.kt @@ -1,4 +1,4 @@ -// "Remove 'get:' target to make the annotation effective (changes semantics, see: https://youtrack.jetbrains.com/issue/KT-48141)" "true" +// "Remove 'get:' to make the annotation effective. (changes semantics. See: https://youtrack.jetbrains.com/issue/KT-48141)" "true" // WITH_STDLIB class Foo { private val bar = 0 diff --git a/plugins/kotlin/idea/tests/testData/quickfix/removeUseSiteTarget/useSiteGetDoesntHaveAnyEffect.kt.after b/plugins/kotlin/idea/tests/testData/quickfix/removeUseSiteTarget/useSiteGetDoesntHaveAnyEffect.kt.after index 8abb4d11471d..a99cc7da8a41 100644 --- a/plugins/kotlin/idea/tests/testData/quickfix/removeUseSiteTarget/useSiteGetDoesntHaveAnyEffect.kt.after +++ b/plugins/kotlin/idea/tests/testData/quickfix/removeUseSiteTarget/useSiteGetDoesntHaveAnyEffect.kt.after @@ -1,4 +1,4 @@ -// "Remove 'get:' target to make the annotation effective (changes semantics, see: https://youtrack.jetbrains.com/issue/KT-48141)" "true" +// "Remove 'get:' to make the annotation effective. (changes semantics. See: https://youtrack.jetbrains.com/issue/KT-48141)" "true" // WITH_STDLIB class Foo { private val bar = 0 diff --git a/plugins/kotlin/idea/tests/testData/quickfix/removeUseSiteTarget/useSiteGetOnClass.kt b/plugins/kotlin/idea/tests/testData/quickfix/removeUseSiteTarget/useSiteGetOnClass.kt index 3b873d753765..b66df6d2da66 100644 --- a/plugins/kotlin/idea/tests/testData/quickfix/removeUseSiteTarget/useSiteGetOnClass.kt +++ b/plugins/kotlin/idea/tests/testData/quickfix/removeUseSiteTarget/useSiteGetOnClass.kt @@ -1,4 +1,4 @@ -// "Remove 'get:' target to make the annotation effective (changes semantics, see: https://youtrack.jetbrains.com/issue/KT-48141)" "false" +// "Remove 'get:' to make the annotation effective. (changes semantics. See: https://youtrack.jetbrains.com/issue/KT-48141)" "false" // IGNORE_FIR // ACTION: Create test // ACTION: Make internal diff --git a/plugins/kotlin/idea/tests/testData/quickfix/removeUseSiteTarget/whitespaces.kt b/plugins/kotlin/idea/tests/testData/quickfix/removeUseSiteTarget/whitespaces.kt index 3132ce3cbc01..6ae53131f12c 100644 --- a/plugins/kotlin/idea/tests/testData/quickfix/removeUseSiteTarget/whitespaces.kt +++ b/plugins/kotlin/idea/tests/testData/quickfix/removeUseSiteTarget/whitespaces.kt @@ -1,4 +1,4 @@ -// "Remove 'get:' target to make the annotation effective (changes semantics, see: https://youtrack.jetbrains.com/issue/KT-48141)" "true" +// "Remove 'get:' to make the annotation effective. (changes semantics. See: https://youtrack.jetbrains.com/issue/KT-48141)" "true" // WITH_STDLIB class Foo { private val bar = 0 diff --git a/plugins/kotlin/idea/tests/testData/quickfix/removeUseSiteTarget/whitespaces.kt.after b/plugins/kotlin/idea/tests/testData/quickfix/removeUseSiteTarget/whitespaces.kt.after index 8abb4d11471d..a99cc7da8a41 100644 --- a/plugins/kotlin/idea/tests/testData/quickfix/removeUseSiteTarget/whitespaces.kt.after +++ b/plugins/kotlin/idea/tests/testData/quickfix/removeUseSiteTarget/whitespaces.kt.after @@ -1,4 +1,4 @@ -// "Remove 'get:' target to make the annotation effective (changes semantics, see: https://youtrack.jetbrains.com/issue/KT-48141)" "true" +// "Remove 'get:' to make the annotation effective. (changes semantics. See: https://youtrack.jetbrains.com/issue/KT-48141)" "true" // WITH_STDLIB class Foo { private val bar = 0