From 28c75d2db12ebb758ca447ff685467ccea886342 Mon Sep 17 00:00:00 2001 From: Bas Leijdekkers Date: Thu, 1 May 2014 23:46:36 +0200 Subject: [PATCH] remove check covered by "Variable is assigned to itself" inspection (IDEA-124559) --- .../defUse/DefUseInspectionBase.java | 24 +------------------ 1 file changed, 1 insertion(+), 23 deletions(-) diff --git a/java/java-analysis-impl/src/com/intellij/codeInspection/defUse/DefUseInspectionBase.java b/java/java-analysis-impl/src/com/intellij/codeInspection/defUse/DefUseInspectionBase.java index 327b24c61ebd..fd441ed17a04 100644 --- a/java/java-analysis-impl/src/com/intellij/codeInspection/defUse/DefUseInspectionBase.java +++ b/java/java-analysis-impl/src/com/intellij/codeInspection/defUse/DefUseInspectionBase.java @@ -1,5 +1,5 @@ /* - * Copyright 2000-2013 JetBrains s.r.o. + * Copyright 2000-2014 JetBrains s.r.o. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -130,28 +130,6 @@ public class DefUseInspectionBase extends BaseJavaBatchLocalInspectionTool { ProblemHighlightType.LIKE_UNUSED_SYMBOL); } } - - @Override public void visitAssignmentExpression(PsiAssignmentExpression expression) { - PsiExpression lExpression = expression.getLExpression(); - PsiExpression rExpression = expression.getRExpression(); - - if (lExpression instanceof PsiReferenceExpression && rExpression instanceof PsiReferenceExpression) { - PsiReferenceExpression lRef = (PsiReferenceExpression)lExpression; - PsiReferenceExpression rRef = (PsiReferenceExpression)rExpression; - - if (lRef.resolve() != rRef.resolve()) return; - PsiExpression lQualifier = lRef.getQualifierExpression(); - PsiExpression rQualifier = rRef.getQualifierExpression(); - - if ((lQualifier == null && rQualifier == null || - lQualifier instanceof PsiThisExpression && rQualifier instanceof PsiThisExpression || - lQualifier instanceof PsiThisExpression && rQualifier == null || - lQualifier == null && rQualifier instanceof PsiThisExpression) && !isOnTheFly) { - holder.registerProblem(expression, - InspectionsBundle.message("inspection.unused.assignment.problem.descriptor6", "#ref")); - } - } - } }); }