diff --git a/jps/model-impl/src/org/jetbrains/jps/model/impl/JpsEventDispatcherBase.java b/jps/model-impl/src/org/jetbrains/jps/model/impl/JpsEventDispatcherBase.java index 7226b3854069..e36362b50dd8 100644 --- a/jps/model-impl/src/org/jetbrains/jps/model/impl/JpsEventDispatcherBase.java +++ b/jps/model-impl/src/org/jetbrains/jps/model/impl/JpsEventDispatcherBase.java @@ -29,7 +29,7 @@ import java.util.Map; * @author nik */ public abstract class JpsEventDispatcherBase implements JpsEventDispatcher { - private Map, EventDispatcher> myDispatchers = new HashMap, EventDispatcher>(); + private final Map, EventDispatcher> myDispatchers = new HashMap, EventDispatcher>(); @NotNull @Override diff --git a/jps/model-impl/src/org/jetbrains/jps/model/java/impl/compiler/JpsCompilerExcludesImpl.java b/jps/model-impl/src/org/jetbrains/jps/model/java/impl/compiler/JpsCompilerExcludesImpl.java index 315347621526..bd3a59974979 100644 --- a/jps/model-impl/src/org/jetbrains/jps/model/java/impl/compiler/JpsCompilerExcludesImpl.java +++ b/jps/model-impl/src/org/jetbrains/jps/model/java/impl/compiler/JpsCompilerExcludesImpl.java @@ -41,11 +41,11 @@ public class JpsCompilerExcludesImpl implements JpsCompilerExcludes { addExcludedDirectory(JpsPathUtil.urlToFile(url), recursively); } - public void addExcludedFile(File file) { + protected void addExcludedFile(File file) { myFiles.add(file); } - public void addExcludedDirectory(File dir, boolean recursively) { + protected void addExcludedDirectory(File dir, boolean recursively) { (recursively ? myRecursivelyExcludedDirectories : myDirectories).add(dir); } diff --git a/jps/model-impl/src/org/jetbrains/jps/model/java/impl/compiler/JpsJavaCompilerConfigurationImpl.java b/jps/model-impl/src/org/jetbrains/jps/model/java/impl/compiler/JpsJavaCompilerConfigurationImpl.java index dfebfa2ce83c..dbf5eac3529f 100644 --- a/jps/model-impl/src/org/jetbrains/jps/model/java/impl/compiler/JpsJavaCompilerConfigurationImpl.java +++ b/jps/model-impl/src/org/jetbrains/jps/model/java/impl/compiler/JpsJavaCompilerConfigurationImpl.java @@ -36,13 +36,13 @@ public class JpsJavaCompilerConfigurationImpl extends JpsCompositeElementBase ROLE = JpsElementChildRoleBase.create("compiler configuration"); private boolean myAddNotNullAssertions = true; private boolean myClearOutputDirectoryOnRebuild = true; - private JpsCompilerExcludes myCompilerExcludes = new JpsCompilerExcludesImpl(); - private List myResourcePatterns = new ArrayList(); - private List myAnnotationProcessingProfiles = new ArrayList(); - private ProcessorConfigProfileImpl myDefaultAnnotationProcessingProfile = new ProcessorConfigProfileImpl("Default"); + private final JpsCompilerExcludes myCompilerExcludes = new JpsCompilerExcludesImpl(); + private final List myResourcePatterns = new ArrayList(); + private final List myAnnotationProcessingProfiles = new ArrayList(); + private final ProcessorConfigProfileImpl myDefaultAnnotationProcessingProfile = new ProcessorConfigProfileImpl("Default"); private String myProjectByteCodeTargetLevel; - private Map myModulesByteCodeTargetLevels = new HashMap(); - private Map myCompilerOptions = new HashMap(); + private final Map myModulesByteCodeTargetLevels = new HashMap(); + private final Map myCompilerOptions = new HashMap(); private String myJavaCompilerId = "Javac"; private Map myAnnotationProcessingProfileMap; private ResourcePatterns myCompiledPatterns; diff --git a/jps/model-impl/src/org/jetbrains/jps/model/java/impl/compiler/ResourcePatterns.java b/jps/model-impl/src/org/jetbrains/jps/model/java/impl/compiler/ResourcePatterns.java index ed62fa4e6561..f1273621f823 100644 --- a/jps/model-impl/src/org/jetbrains/jps/model/java/impl/compiler/ResourcePatterns.java +++ b/jps/model-impl/src/org/jetbrains/jps/model/java/impl/compiler/ResourcePatterns.java @@ -160,7 +160,7 @@ public class ResourcePatterns { return wildcardPattern; } - public static boolean isPatternNegated(String wildcardPattern) { + private static boolean isPatternNegated(String wildcardPattern) { return wildcardPattern.length() > 1 && wildcardPattern.charAt(0) == '!'; } diff --git a/jps/model-impl/src/org/jetbrains/jps/model/library/impl/JpsLibraryRole.java b/jps/model-impl/src/org/jetbrains/jps/model/library/impl/JpsLibraryRole.java index 1c1492058878..0da1aadbfee1 100644 --- a/jps/model-impl/src/org/jetbrains/jps/model/library/impl/JpsLibraryRole.java +++ b/jps/model-impl/src/org/jetbrains/jps/model/library/impl/JpsLibraryRole.java @@ -26,7 +26,7 @@ import org.jetbrains.jps.model.library.JpsLibraryListener; * @author nik */ public class JpsLibraryRole extends JpsElementChildRoleBase { - public static final JpsLibraryRole INSTANCE = new JpsLibraryRole(); + private static final JpsLibraryRole INSTANCE = new JpsLibraryRole(); public static final JpsElementCollectionRole LIBRARIES_COLLECTION_ROLE = JpsElementCollectionRole.create(INSTANCE); private JpsLibraryRole() { diff --git a/jps/model-impl/src/org/jetbrains/jps/model/module/impl/JpsModuleImpl.java b/jps/model-impl/src/org/jetbrains/jps/model/module/impl/JpsModuleImpl.java index 8bf2845b136a..68fa7674ebda 100644 --- a/jps/model-impl/src/org/jetbrains/jps/model/module/impl/JpsModuleImpl.java +++ b/jps/model-impl/src/org/jetbrains/jps/model/module/impl/JpsModuleImpl.java @@ -40,7 +40,7 @@ import java.util.List; public class JpsModuleImpl

extends JpsNamedCompositeElementBase> implements JpsTypedModule

{ private static final JpsUrlListRole CONTENT_ROOTS_ROLE = new JpsUrlListRole("content roots"); private static final JpsUrlListRole EXCLUDED_ROOTS_ROLE = new JpsUrlListRole("excluded roots"); - public static final JpsElementChildRole DEPENDENCIES_LIST_CHILD_ROLE = JpsElementChildRoleBase.create("dependencies"); + private static final JpsElementChildRole DEPENDENCIES_LIST_CHILD_ROLE = JpsElementChildRoleBase.create("dependencies"); private final JpsModuleType

myModuleType; private final JpsLibraryCollection myLibraryCollection;