From 27df9141849eae4e9084680e0369a574eee084b8 Mon Sep 17 00:00:00 2001 From: nik Date: Thu, 2 Dec 2010 16:49:47 +0300 Subject: [PATCH] IDEA-61567: Groovy and grails New SDK not stored for later use (regression) [rev by peter] --- .../impl/ui/libraries/LibraryCompositionSettings.java | 5 ++--- .../configuration/libraries/CustomLibraryDescription.java | 6 ++++++ .../plugins/groovy/config/GroovyLibraryDescription.java | 7 +++++++ 3 files changed, 15 insertions(+), 3 deletions(-) diff --git a/java/idea-ui/src/com/intellij/facet/impl/ui/libraries/LibraryCompositionSettings.java b/java/idea-ui/src/com/intellij/facet/impl/ui/libraries/LibraryCompositionSettings.java index 1c950688d919..e325d88526b8 100644 --- a/java/idea-ui/src/com/intellij/facet/impl/ui/libraries/LibraryCompositionSettings.java +++ b/java/idea-ui/src/com/intellij/facet/impl/ui/libraries/LibraryCompositionSettings.java @@ -17,7 +17,6 @@ package com.intellij.facet.impl.ui.libraries; import com.intellij.openapi.Disposable; import com.intellij.openapi.roots.ModifiableRootModel; -import com.intellij.openapi.roots.OrderRootType; import com.intellij.openapi.roots.libraries.Library; import com.intellij.openapi.roots.ui.configuration.libraries.CustomLibraryDescription; import com.intellij.openapi.roots.ui.configuration.libraries.LibraryDownloadDescription; @@ -26,7 +25,6 @@ import com.intellij.openapi.roots.ui.configuration.libraryEditor.NewLibraryEdito import com.intellij.openapi.roots.ui.configuration.projectRoot.LibrariesContainer; import com.intellij.openapi.roots.ui.configuration.projectRoot.LibrariesContainerFactory; import com.intellij.openapi.util.Disposer; -import com.intellij.openapi.vfs.VirtualFile; import org.jetbrains.annotations.NotNull; import org.jetbrains.annotations.Nullable; @@ -41,7 +39,7 @@ import java.util.Map; public class LibraryCompositionSettings implements Disposable { private final CustomLibraryDescription myLibraryDescription; private final String myBaseDirectoryPath; - private LibrariesContainer.LibraryLevel myNewLibraryLevel = LibrariesContainer.LibraryLevel.PROJECT; + private LibrariesContainer.LibraryLevel myNewLibraryLevel; private NewLibraryEditor myNewLibraryEditor; private Library mySelectedLibrary; private boolean myDownloadLibraries; @@ -51,6 +49,7 @@ public class LibraryCompositionSettings implements Disposable { public LibraryCompositionSettings(final @NotNull CustomLibraryDescription libraryDescription, final @NotNull String baseDirectoryFiles) { myLibraryDescription = libraryDescription; + myNewLibraryLevel = libraryDescription.getDefaultLevel(); myBaseDirectoryPath = baseDirectoryFiles; final LibraryDownloadDescription downloadDescription = myLibraryDescription.getDownloadDescription(); if (downloadDescription != null) { diff --git a/java/idea-ui/src/com/intellij/openapi/roots/ui/configuration/libraries/CustomLibraryDescription.java b/java/idea-ui/src/com/intellij/openapi/roots/ui/configuration/libraries/CustomLibraryDescription.java index c63eefb73239..1186e765ef94 100644 --- a/java/idea-ui/src/com/intellij/openapi/roots/ui/configuration/libraries/CustomLibraryDescription.java +++ b/java/idea-ui/src/com/intellij/openapi/roots/ui/configuration/libraries/CustomLibraryDescription.java @@ -15,6 +15,7 @@ */ package com.intellij.openapi.roots.ui.configuration.libraries; +import com.intellij.openapi.roots.ui.configuration.projectRoot.LibrariesContainer; import com.intellij.openapi.util.Condition; import com.intellij.openapi.vfs.VirtualFile; import org.jetbrains.annotations.NotNull; @@ -37,4 +38,9 @@ public abstract class CustomLibraryDescription { @Nullable public abstract NewLibraryConfiguration createNewLibrary(@NotNull JComponent parentComponent, @Nullable VirtualFile contextDirectory); + + @NotNull + public LibrariesContainer.LibraryLevel getDefaultLevel() { + return LibrariesContainer.LibraryLevel.PROJECT; + } } diff --git a/plugins/groovy/src/org/jetbrains/plugins/groovy/config/GroovyLibraryDescription.java b/plugins/groovy/src/org/jetbrains/plugins/groovy/config/GroovyLibraryDescription.java index e14452647ffc..8eae8b1b9450 100644 --- a/plugins/groovy/src/org/jetbrains/plugins/groovy/config/GroovyLibraryDescription.java +++ b/plugins/groovy/src/org/jetbrains/plugins/groovy/config/GroovyLibraryDescription.java @@ -23,6 +23,7 @@ import com.intellij.openapi.roots.ui.configuration.libraries.CustomLibraryDescri import com.intellij.openapi.roots.ui.configuration.libraries.LibraryPresentationManager; import com.intellij.openapi.roots.ui.configuration.libraries.NewLibraryConfiguration; import com.intellij.openapi.roots.ui.configuration.libraryEditor.LibraryEditor; +import com.intellij.openapi.roots.ui.configuration.projectRoot.LibrariesContainer; import com.intellij.openapi.util.Condition; import com.intellij.openapi.util.io.FileUtil; import com.intellij.openapi.vfs.LocalFileSystem; @@ -149,4 +150,10 @@ public class GroovyLibraryDescription extends CustomLibraryDescription { } }; } + + @NotNull + @Override + public LibrariesContainer.LibraryLevel getDefaultLevel() { + return LibrariesContainer.LibraryLevel.GLOBAL; + } }