From 25e4279563997781241069e38cfde6beed6d32f1 Mon Sep 17 00:00:00 2001 From: Mikhail Golubev Date: Mon, 13 Jan 2014 13:54:45 +0400 Subject: [PATCH] Simplify check, that certificates chain is self-signed --- .../src/com/intellij/util/net/CertificatesManager.java | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/platform/platform-api/src/com/intellij/util/net/CertificatesManager.java b/platform/platform-api/src/com/intellij/util/net/CertificatesManager.java index 7ae56b203b13..16cd2c2a5fe1 100644 --- a/platform/platform-api/src/com/intellij/util/net/CertificatesManager.java +++ b/platform/platform-api/src/com/intellij/util/net/CertificatesManager.java @@ -83,6 +83,7 @@ public class CertificatesManager implements ApplicationComponent { // Don't do this: protocol created this way will ignore SSL tunnels. See IDEA-115708. // Protocol.registerProtocol("https", CertificatesManager.createDefault().createProtocol()); SSLContext.setDefault(getSslContext()); + LOG.debug("Default SSL context initialized"); } catch (Exception e) { LOG.error(e); @@ -194,7 +195,7 @@ public class CertificatesManager implements ApplicationComponent { catch (CertificateException e1) { X509Certificate certificate = certificates[0]; // looks like self-signed certificate - if (certificates.length == 1 && certificateIsSelfSigned(certificate)) { + if (certificates.length == 1) { // check-then-act sequence synchronized (myCustomManager) { try { @@ -395,8 +396,4 @@ public class CertificatesManager implements ApplicationComponent { } return null; } - - private static boolean certificateIsSelfSigned(X509Certificate certificate) { - return certificate.getIssuerX500Principal().equals(certificate.getSubjectX500Principal()); - } }