From 25da1af8200dd84f064c21b3fbeca6c036aa8590 Mon Sep 17 00:00:00 2001
From: Tagir Valeev <Tagir.Valeev@jetbrains.com>
Date: Tue, 25 Sep 2018 16:06:15 +0700
Subject: [PATCH] Method with same arguments message updated (IDEA-142026)

---
 .../inspection/dataFlow/fixture/SameArguments.java     | 10 +++++-----
 .../src/messages/InspectionsBundle.properties          |  2 +-
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/java/java-tests/testData/inspection/dataFlow/fixture/SameArguments.java b/java/java-tests/testData/inspection/dataFlow/fixture/SameArguments.java
index 6ca7e2cf235e..6746d468866f 100644
--- a/java/java-tests/testData/inspection/dataFlow/fixture/SameArguments.java
+++ b/java/java-tests/testData/inspection/dataFlow/fixture/SameArguments.java
@@ -1,16 +1,16 @@
 class X {
   void test(int x, int y) {
-    System.out.println(Math.<warning descr="Arguments of 'max()' are always the same which unlikely makes sense">max</warning>(x, x));
+    System.out.println(Math.<warning descr="Arguments of 'max' are the same. Calling this method with the same arguments is meaningless.">max</warning>(x, x));
     int z = x;
-    System.out.println(Math.<warning descr="Arguments of 'min()' are always the same which unlikely makes sense">min</warning>(x, z));
+    System.out.println(Math.<warning descr="Arguments of 'min' are the same. Calling this method with the same arguments is meaningless.">min</warning>(x, z));
     String s = "foo";
     String t = "foo";
-    System.out.println("foobar".<warning descr="Arguments of 'replace()' are always the same which unlikely makes sense">replace</warning>(s, t));
-    System.out.println("foobar".<warning descr="Arguments of 'replace()' are always the same which unlikely makes sense">replace</warning>('x', 'x'));
+    System.out.println("foobar".<warning descr="Arguments of 'replace' are the same. Calling this method with the same arguments is meaningless.">replace</warning>(s, t));
+    System.out.println("foobar".<warning descr="Arguments of 'replace' are the same. Calling this method with the same arguments is meaningless.">replace</warning>('x', 'x'));
   }
 
   int testCondition(int a) {
-    if(a == 100) return Math.<warning descr="Arguments of 'max()' are always the same which unlikely makes sense">max</warning>(a, 100);
+    if(a == 100) return Math.<warning descr="Arguments of 'max' are the same. Calling this method with the same arguments is meaningless.">max</warning>(a, 100);
     return 0;
   }
 }
\ No newline at end of file
diff --git a/platform/platform-resources-en/src/messages/InspectionsBundle.properties b/platform/platform-resources-en/src/messages/InspectionsBundle.properties
index 51253a5c1cc9..68805160727f 100644
--- a/platform/platform-resources-en/src/messages/InspectionsBundle.properties
+++ b/platform/platform-resources-en/src/messages/InspectionsBundle.properties
@@ -97,7 +97,7 @@ dataflow.message.array.index.out.of.bounds=Array index is out of bounds
 dataflow.message.immutable.modified=Immutable object is modified
 dataflow.message.immutable.passed=Immutable object is passed where mutable is expected
 dataflow.message.redundant.assignment=Variable is already assigned to this value
-dataflow.message.pointless.same.arguments=Arguments of '#ref()' are always the same which unlikely makes sense
+dataflow.message.pointless.same.arguments=Arguments of '#ref' are the same. Calling this method with the same arguments is meaningless.
 
 inspection.optional.get.without.is.present.message=<code>{0}.#ref()</code> without ''isPresent()'' check