From 70097dba15d16457c4aef2e3f1bb4b41967418b1 Mon Sep 17 00:00:00 2001 From: peter Date: Mon, 30 Apr 2012 10:19:16 +0200 Subject: [PATCH 1/2] more on dom equals/hashCode --- .../util/xml/impl/ConvertAnnotationImpl.java | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/xml/dom-impl/src/com/intellij/util/xml/impl/ConvertAnnotationImpl.java b/xml/dom-impl/src/com/intellij/util/xml/impl/ConvertAnnotationImpl.java index fcd624861459..2fcb9ebe2507 100644 --- a/xml/dom-impl/src/com/intellij/util/xml/impl/ConvertAnnotationImpl.java +++ b/xml/dom-impl/src/com/intellij/util/xml/impl/ConvertAnnotationImpl.java @@ -48,4 +48,23 @@ public class ConvertAnnotationImpl implements Convert { return mySoft; } + @Override + public boolean equals(Object o) { + if (this == o) return true; + if (!(o instanceof ConvertAnnotationImpl)) return false; + + ConvertAnnotationImpl that = (ConvertAnnotationImpl)o; + + if (mySoft != that.mySoft) return false; + if (!myConverter.getClass().equals(that.myConverter.getClass())) return false; + + return true; + } + + @Override + public int hashCode() { + int result = myConverter.getClass().hashCode(); + result = 31 * result + (mySoft ? 1 : 0); + return result; + } } From 33c5249da84e09c0dea5cdf6ebbed9333688ea37 Mon Sep 17 00:00:00 2001 From: anna Date: Mon, 30 Apr 2012 10:46:34 +0200 Subject: [PATCH 2/2] fix unused declaration after wrapper introduced, once more (IDEA-85153) --- .../ex/CommonInspectionToolWrapper.java | 96 ++++++++++++++++++- 1 file changed, 93 insertions(+), 3 deletions(-) diff --git a/platform/lang-impl/src/com/intellij/codeInspection/ex/CommonInspectionToolWrapper.java b/platform/lang-impl/src/com/intellij/codeInspection/ex/CommonInspectionToolWrapper.java index 7ea0d0b8d2e1..30a41b4f76c7 100644 --- a/platform/lang-impl/src/com/intellij/codeInspection/ex/CommonInspectionToolWrapper.java +++ b/platform/lang-impl/src/com/intellij/codeInspection/ex/CommonInspectionToolWrapper.java @@ -16,15 +16,21 @@ package com.intellij.codeInspection.ex; import com.intellij.analysis.AnalysisScope; -import com.intellij.codeInspection.GlobalInspectionContext; -import com.intellij.codeInspection.InspectionEP; -import com.intellij.codeInspection.InspectionManager; +import com.intellij.codeInsight.intention.IntentionAction; +import com.intellij.codeInspection.*; +import com.intellij.codeInspection.reference.RefElement; import com.intellij.codeInspection.reference.RefEntity; +import com.intellij.codeInspection.reference.RefManager; +import com.intellij.codeInspection.reference.RefModule; import com.intellij.codeInspection.ui.InspectionNode; import com.intellij.codeInspection.ui.InspectionTreeNode; +import com.intellij.lang.annotation.HighlightSeverity; +import com.intellij.openapi.vcs.FileStatus; import org.jdom.Element; import org.jetbrains.annotations.NotNull; +import org.jetbrains.annotations.Nullable; +import java.util.Collection; import java.util.Map; import java.util.Set; @@ -51,6 +57,11 @@ public class CommonInspectionToolWrapper extends InspectionToolWrapper getModuleProblems() { + return getTool().getModuleProblems(); + } + + @Override + public boolean isOldProblemsIncluded() { + return getTool().isOldProblemsIncluded(); + } + + @Override + @Nullable + public Map> getOldContent() { + return getTool().getOldContent(); + } + @Override public boolean queryExternalUsagesRequests(InspectionManager manager) { return getTool().queryExternalUsagesRequests(manager); @@ -113,4 +178,29 @@ public class CommonInspectionToolWrapper extends InspectionToolWrapper getIgnoredRefElements() { + return getTool().getIgnoredRefElements(); + } + + @Nullable + public SuppressIntentionAction[] getSuppressActions() { + return getTool().getSuppressActions(); + } }