From 611502e95c12c79055b68a183e6c417af9f21c08 Mon Sep 17 00:00:00 2001 From: "Denis.Zhdanov" Date: Mon, 5 Aug 2013 18:07:34 +0400 Subject: [PATCH] IDEA-111551 Gradle: JVM options are not saved until changing some of the gradle settings --- .../service/settings/GradleSystemSettingsControl.java | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/plugins/gradle/src/org/jetbrains/plugins/gradle/service/settings/GradleSystemSettingsControl.java b/plugins/gradle/src/org/jetbrains/plugins/gradle/service/settings/GradleSystemSettingsControl.java index 35b34ee143df..721140dde838 100644 --- a/plugins/gradle/src/org/jetbrains/plugins/gradle/service/settings/GradleSystemSettingsControl.java +++ b/plugins/gradle/src/org/jetbrains/plugins/gradle/service/settings/GradleSystemSettingsControl.java @@ -136,12 +136,16 @@ public class GradleSystemSettingsControl implements ExternalSystemSettingsContro return (myServiceDirectoryPathModifiedByUser && !Comparing.equal(ExternalSystemApiUtil.normalizePath(myServiceDirectoryPathField.getText()), ExternalSystemApiUtil.normalizePath(myInitialSettings.getServiceDirectoryPath()))) - || myInitialSettings.getGradleVmOptions() != null && !Comparing.equal(trimIfPossible(myGradleVmOptionsField.getText()), trimIfPossible(myInitialSettings.getGradleVmOptions())); + || !Comparing.equal(trimIfPossible(myGradleVmOptionsField.getText()), trimIfPossible(myInitialSettings.getGradleVmOptions())); } @Nullable private static String trimIfPossible(@Nullable String s) { - return s == null ? null : s.trim(); + if (s == null) { + return null; + } + String result = s.trim(); + return result.isEmpty() ? null : result; } @Override