From 232d4fe39c2dd61e1e31b578a5d65b4ca0affa26 Mon Sep 17 00:00:00 2001 From: Dmitriy Smirnov Date: Tue, 31 Jul 2018 00:38:25 +0300 Subject: [PATCH] IDEA-196449 Do not try setting git user name and email for non-git repositories --- .../src/git4idea/checkin/GitCheckinHandlerFactory.java | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/plugins/git4idea/src/git4idea/checkin/GitCheckinHandlerFactory.java b/plugins/git4idea/src/git4idea/checkin/GitCheckinHandlerFactory.java index 89347309e48d..cf16f7f3b31f 100644 --- a/plugins/git4idea/src/git4idea/checkin/GitCheckinHandlerFactory.java +++ b/plugins/git4idea/src/git4idea/checkin/GitCheckinHandlerFactory.java @@ -26,10 +26,7 @@ import com.intellij.openapi.ui.Messages; import com.intellij.openapi.util.Couple; import com.intellij.openapi.util.Pair; import com.intellij.openapi.util.Ref; -import com.intellij.openapi.vcs.CheckinProjectPanel; -import com.intellij.openapi.vcs.FilePath; -import com.intellij.openapi.vcs.ProjectLevelVcsManager; -import com.intellij.openapi.vcs.VcsException; +import com.intellij.openapi.vcs.*; import com.intellij.openapi.vcs.changes.ChangesUtil; import com.intellij.openapi.vcs.changes.CommitExecutor; import com.intellij.openapi.vcs.checkin.CheckinHandler; @@ -378,10 +375,12 @@ public class GitCheckinHandlerFactory extends VcsCheckinHandlerFactory { @NotNull private Collection getSelectedRoots() { ProjectLevelVcsManager vcsManager = ProjectLevelVcsManager.getInstance(myProject); + GitVcs git = GitVcs.getInstance(myProject); Collection result = new HashSet<>(); for (FilePath path : ChangesUtil.getPaths(myPanel.getSelectedChanges())) { + AbstractVcs vcs = vcsManager.getVcsFor(path); VirtualFile root = vcsManager.getVcsRootFor(path); - if (root != null) { + if (vcs.equals(git) && root != null) { result.add(root); } }