From 22e67cafddc673342fffbe2fa8493fdf6beca7c6 Mon Sep 17 00:00:00 2001 From: Mikhail Pyltsin Date: Mon, 23 Jan 2023 17:42:49 +0100 Subject: [PATCH] [jvm-inspections] IDEA-310343 Patterns as arguments for logging GitOrigin-RevId: 904ee15422954df774ea8514ee86a453a8e53ded --- .../logging/LoggingStringTemplateAsArgumentInspection.kt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/jvm/jvm-analysis-impl/src/com/intellij/codeInspection/logging/LoggingStringTemplateAsArgumentInspection.kt b/jvm/jvm-analysis-impl/src/com/intellij/codeInspection/logging/LoggingStringTemplateAsArgumentInspection.kt index e3a59d2189ff..6b65baf5cc84 100644 --- a/jvm/jvm-analysis-impl/src/com/intellij/codeInspection/logging/LoggingStringTemplateAsArgumentInspection.kt +++ b/jvm/jvm-analysis-impl/src/com/intellij/codeInspection/logging/LoggingStringTemplateAsArgumentInspection.kt @@ -34,13 +34,13 @@ private class LoggingStringTemplateAsArgumentVisitor( if (valueArguments.isEmpty()) return true var stringExpression = valueArguments[0] var indexStringExpression = 0 - if (!canBePattern(stringExpression.getExpressionType())) { + if (!canBeText(stringExpression.getExpressionType())) { if (valueArguments.size < 2) { return true } stringExpression = valueArguments[1] indexStringExpression = 1 - if (!canBePattern(stringExpression.getExpressionType())) { + if (!canBeText(stringExpression.getExpressionType())) { return true } } @@ -61,7 +61,7 @@ private class LoggingStringTemplateAsArgumentVisitor( !stringExpression.operands.all { it is ULiteralExpression } } - private fun canBePattern(expressionType: PsiType?): Boolean { + private fun canBeText(expressionType: PsiType?): Boolean { if ( expressionType?.equalsToText(CommonClassNames.JAVA_LANG_STRING) == true || expressionType?.equalsToText(CommonClassNames.JAVA_LANG_CHAR_SEQUENCE) == true