From f4053b9e2d47c2aed60a701764934b4327aecd29 Mon Sep 17 00:00:00 2001 From: "Gregory.Shrago" Date: Thu, 25 Jul 2013 19:09:38 +0400 Subject: [PATCH 1/2] IDEA-110933 Database table editor: in editing mode attempt to move focus to different view immediately moves it back --- .../intellij/openapi/fileEditor/impl/EditorsSplitters.java | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/platform/platform-impl/src/com/intellij/openapi/fileEditor/impl/EditorsSplitters.java b/platform/platform-impl/src/com/intellij/openapi/fileEditor/impl/EditorsSplitters.java index 7cb99dd389c4..f6bb0cc994e3 100644 --- a/platform/platform-impl/src/com/intellij/openapi/fileEditor/impl/EditorsSplitters.java +++ b/platform/platform-impl/src/com/intellij/openapi/fileEditor/impl/EditorsSplitters.java @@ -58,6 +58,7 @@ import javax.swing.*; import java.awt.*; import java.awt.datatransfer.DataFlavor; import java.awt.datatransfer.Transferable; +import java.awt.event.ContainerEvent; import java.io.File; import java.util.*; import java.util.List; @@ -827,6 +828,11 @@ public class EditorsSplitters extends JBPanel { if (component != null) { newWindow = findWindowWith(component); } + else if (cause instanceof ContainerEvent && cause.getID() == ContainerEvent.COMPONENT_REMOVED) { + // do not change current window in case of child removal as in JTable.removeEditor + // otherwise Escape in a toolwindow will not focus editor with JTable content + return; + } setCurrentWindow(newWindow); setCurrentWindow(newWindow, false); From f197f9f472fe7c894bb988f4129b3724432566dd Mon Sep 17 00:00:00 2001 From: Dmitry Jemerov Date: Thu, 25 Jul 2013 16:52:12 +0200 Subject: [PATCH 2/2] passing a name to ModuleBasedConfiguration constructor is optional; kill a lot of code for passing around empty names --- .../com/intellij/execution/applet/AppletConfiguration.java | 4 ++-- .../intellij/execution/applet/AppletConfigurationType.java | 2 +- .../com/intellij/execution/remote/RemoteConfiguration.java | 4 ++-- .../intellij/execution/remote/RemoteConfigurationType.java | 2 +- .../execution/configuration/AbstractRunConfiguration.java | 5 +++++ .../execution/configurations/ModuleBasedConfiguration.java | 5 +++++ 6 files changed, 16 insertions(+), 6 deletions(-) diff --git a/java/execution/impl/src/com/intellij/execution/applet/AppletConfiguration.java b/java/execution/impl/src/com/intellij/execution/applet/AppletConfiguration.java index b8b935f8e426..8a51328e5f98 100644 --- a/java/execution/impl/src/com/intellij/execution/applet/AppletConfiguration.java +++ b/java/execution/impl/src/com/intellij/execution/applet/AppletConfiguration.java @@ -69,8 +69,8 @@ public class AppletConfiguration extends ModuleBasedConfiguration getEnvs() { return myEnvs; } diff --git a/platform/lang-api/src/com/intellij/execution/configurations/ModuleBasedConfiguration.java b/platform/lang-api/src/com/intellij/execution/configurations/ModuleBasedConfiguration.java index e72537bd3ea0..952079303289 100644 --- a/platform/lang-api/src/com/intellij/execution/configurations/ModuleBasedConfiguration.java +++ b/platform/lang-api/src/com/intellij/execution/configurations/ModuleBasedConfiguration.java @@ -45,6 +45,11 @@ public abstract class ModuleBasedConfiguration getValidModules(); public ConfigurationModule getConfigurationModule() {