From 21480ad35f04df48a35f9606444d6ee519d73e3d Mon Sep 17 00:00:00 2001 From: "Anna.Kozlova" Date: Tue, 11 Jul 2017 16:30:04 +0200 Subject: [PATCH] constructor -> builder: allow setters when no default value specified (IDEA-175530) --- .../ReplaceConstructorWithBuilderDialog.java | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/java/java-impl/src/com/intellij/refactoring/replaceConstructorWithBuilder/ReplaceConstructorWithBuilderDialog.java b/java/java-impl/src/com/intellij/refactoring/replaceConstructorWithBuilder/ReplaceConstructorWithBuilderDialog.java index 67c3ef94f8f1..fb8fb60d5d72 100644 --- a/java/java-impl/src/com/intellij/refactoring/replaceConstructorWithBuilder/ReplaceConstructorWithBuilderDialog.java +++ b/java/java-impl/src/com/intellij/refactoring/replaceConstructorWithBuilder/ReplaceConstructorWithBuilderDialog.java @@ -19,7 +19,10 @@ package com.intellij.refactoring.replaceConstructorWithBuilder; import com.intellij.ide.util.PropertiesComponent; import com.intellij.ide.util.TreeClassChooser; import com.intellij.ide.util.TreeClassChooserFactory; -import com.intellij.openapi.actionSystem.*; +import com.intellij.openapi.actionSystem.ActionManager; +import com.intellij.openapi.actionSystem.AnAction; +import com.intellij.openapi.actionSystem.AnActionEvent; +import com.intellij.openapi.actionSystem.DefaultActionGroup; import com.intellij.openapi.diagnostic.Logger; import com.intellij.openapi.editor.event.DocumentListener; import com.intellij.openapi.options.ConfigurationException; @@ -363,12 +366,7 @@ public class ReplaceConstructorWithBuilderDialog extends RefactoringDialog { @Override public boolean isCellEditable(int rowIndex, int columnIndex) { - if (columnIndex == PARAM) return false; - if (columnIndex == SKIP_SETTER) { - final ParameterData data = getParamData(rowIndex); - if (data.getDefaultValue() == null) return false; - } - return true; + return columnIndex != PARAM; } @Override