#ref() called in an internationalized context #loc
instantiating.simpledateformat.without.locale.display.name=Instantiating a SimpleDateFormat without a Locale
instantiating.simpledateformat.without.locale.problem.descriptor=Instantiating a #ref without specifying a Locale in an internationalized context #loc
-string.compareto.call.display.name=Call to 'String.compareTo()'
-string.compareto.call.problem.descriptor=String.#ref() called using internationalized strings #loc
string.concatenation.display.name=String concatenation
string.concatenation.problem.descriptor=String concatenation #ref in an internationalized context #loc
string.concatenation.ignore.system.out.option=Ignore for 'System.out.print' arguments
@@ -332,10 +330,6 @@ string.concatenation.ignore.constant.initializers.option=Ignore for initializers
ignore.in.annotations=Ignore in annotations
ignore.in.tostring=Ignore inside toString() methods
ignore.as.initial.capacity=Ignore initial capacity for StringBuilders and Collections
-string.equalsignorecase.call.display.name=Call to 'String.equalsIgnoreCase()'
-string.equalsignorecase.call.problem.descriptor=String.#ref() using internationalized strings #loc
-string.equals.call.display.name=Call to 'String.equals()'
-string.equals.call.problem.descriptor=String.#ref() using internationalized strings #loc
string.touppercase.tolowercase.without.locale.display.name=Call to 'String.toUpperCase()' or 'toLowerCase()' without a Locale
string.touppercase.tolowercase.without.locale.problem.descriptor=String.#ref() called without specifying a Locale using internationalized strings #loc
use.stringtokenizer.display.name=Use of StringTokenizer
@@ -2205,3 +2199,5 @@ wait.notify.while.not.synchronized.on.problem.descriptor=Call to #refString.#ref() called in internationalized context #loc
diff --git a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/internationalization/StringEqualsInspection.java b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/internationalization/CallToSuspiciousStringMethodInspection.java
similarity index 51%
rename from plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/internationalization/StringEqualsInspection.java
rename to plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/internationalization/CallToSuspiciousStringMethodInspection.java
index 3da029b5c112..32b9eaea5bf8 100644
--- a/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/internationalization/StringEqualsInspection.java
+++ b/plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/internationalization/CallToSuspiciousStringMethodInspection.java
@@ -1,5 +1,5 @@
/*
- * Copyright 2003-2010 Dave Griffith, Bas Leijdekkers
+ * Copyright 2000-2016 JetBrains s.r.o.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
@@ -24,90 +24,70 @@ import com.siyeh.ig.BaseInspectionVisitor;
import com.siyeh.ig.DelegatingFix;
import com.siyeh.ig.InspectionGadgetsFix;
import com.siyeh.ig.psiutils.MethodCallUtils;
-import com.siyeh.ig.psiutils.TypeUtils;
+import org.jetbrains.annotations.Nls;
import org.jetbrains.annotations.NotNull;
import java.util.ArrayList;
import java.util.List;
-public class StringEqualsInspection extends BaseInspection {
+/**
+ * @author Bas Leijdekkers
+ */
+public class CallToSuspiciousStringMethodInspection extends BaseInspection {
- @Override
+ @Nls
@NotNull
- public String getID() {
- return "CallToStringEquals";
- }
-
@Override
- @NotNull
public String getDisplayName() {
- return InspectionGadgetsBundle.message(
- "string.equals.call.display.name");
+ return InspectionGadgetsBundle.message("call.to.suspicious.string.method.display.name");
+ }
+
+ @NotNull
+ @Override
+ protected String buildErrorString(Object... infos) {
+ return InspectionGadgetsBundle.message("call.to.suspicious.string.method.problem.descriptor");
}
@Override
- @NotNull
- public String buildErrorString(Object... infos) {
- return InspectionGadgetsBundle.message(
- "string.equals.call.problem.descriptor");
+ public BaseInspectionVisitor buildVisitor() {
+ return new CallToSuspiciousStringMethodVisitor();
}
@Override
@NotNull
protected InspectionGadgetsFix[] buildFixes(Object... infos) {
- final PsiMethodCallExpression methodCallExpression =
- (PsiMethodCallExpression)infos[0];
- final List+ + + \ No newline at end of file diff --git a/plugins/InspectionGadgets/src/inspectionDescriptions/StringCompareTo.html b/plugins/InspectionGadgets/src/inspectionDescriptions/StringCompareTo.html deleted file mode 100644 index d4bf66f9ac8f..000000000000 --- a/plugins/InspectionGadgets/src/inspectionDescriptions/StringCompareTo.html +++ /dev/null @@ -1,9 +0,0 @@ - -
-Reports any call of compareTo() on String objects. Such calls are usually -incorrect in an internationalized environment. - -- - - \ No newline at end of file diff --git a/plugins/InspectionGadgets/src/inspectionDescriptions/StringEquals.html b/plugins/InspectionGadgets/src/inspectionDescriptions/StringEquals.html deleted file mode 100644 index d9ad1a0fb6bd..000000000000 --- a/plugins/InspectionGadgets/src/inspectionDescriptions/StringEquals.html +++ /dev/null @@ -1,9 +0,0 @@ - -
-Reports any call of equals() on String objects. Such calls are usually -incorrect in an internationalized environment. - -- - - \ No newline at end of file diff --git a/plugins/InspectionGadgets/src/inspectionDescriptions/StringEqualsIgnoreCase.html b/plugins/InspectionGadgets/src/inspectionDescriptions/StringEqualsIgnoreCase.html deleted file mode 100644 index 3556e6472e39..000000000000 --- a/plugins/InspectionGadgets/src/inspectionDescriptions/StringEqualsIgnoreCase.html +++ /dev/null @@ -1,9 +0,0 @@ - -
-Reports any call of equalsIgnoreCase() on String objects. Such calls are usually -incorrect in an internationalized environment. - -
-
-
-
\ No newline at end of file
diff --git a/plugins/InspectionGadgets/test/com/siyeh/igtest/internationalization/StringCompareToInspection.java b/plugins/InspectionGadgets/test/com/siyeh/igtest/internationalization/StringCompareToInspection.java
deleted file mode 100644
index df6da4d5e838..000000000000
--- a/plugins/InspectionGadgets/test/com/siyeh/igtest/internationalization/StringCompareToInspection.java
+++ /dev/null
@@ -1,13 +0,0 @@
-package com.siyeh.igtest.internationalization;
-
-public class StringCompareToInspection
-{
- public StringCompareToInspection()
- {
- }
-
- public void foo()
- {
- "foo".compareTo("bar");
- }
-}
\ No newline at end of file
diff --git a/plugins/InspectionGadgets/test/com/siyeh/igtest/internationalization/StringEqualsIgnoreCaseInspection.java b/plugins/InspectionGadgets/test/com/siyeh/igtest/internationalization/StringEqualsIgnoreCaseInspection.java
deleted file mode 100644
index 1fab129ff45f..000000000000
--- a/plugins/InspectionGadgets/test/com/siyeh/igtest/internationalization/StringEqualsIgnoreCaseInspection.java
+++ /dev/null
@@ -1,13 +0,0 @@
-package com.siyeh.igtest.internationalization;
-
-public class StringEqualsIgnoreCaseInspection
-{
- public StringEqualsIgnoreCaseInspection()
- {
- }
-
- public void foo()
- {
- "foo".equalsIgnoreCase("bar");
- }
-}
\ No newline at end of file
diff --git a/plugins/InspectionGadgets/test/com/siyeh/igtest/internationalization/StringEqualsInspection.java b/plugins/InspectionGadgets/test/com/siyeh/igtest/internationalization/StringEqualsInspection.java
deleted file mode 100644
index aa1754bdc48a..000000000000
--- a/plugins/InspectionGadgets/test/com/siyeh/igtest/internationalization/StringEqualsInspection.java
+++ /dev/null
@@ -1,13 +0,0 @@
-package com.siyeh.igtest.internationalization;
-
-public class StringEqualsInspection
-{
- public StringEqualsInspection()
- {
- }
-
- public void foo()
- {
- "foo".equals("bar");
- }
-}
\ No newline at end of file
diff --git a/plugins/InspectionGadgets/test/com/siyeh/igtest/internationalization/call_to_suspicious_string_method/CallToSuspiciousStringMethod.java b/plugins/InspectionGadgets/test/com/siyeh/igtest/internationalization/call_to_suspicious_string_method/CallToSuspiciousStringMethod.java
new file mode 100644
index 000000000000..2404b3bd291f
--- /dev/null
+++ b/plugins/InspectionGadgets/test/com/siyeh/igtest/internationalization/call_to_suspicious_string_method/CallToSuspiciousStringMethod.java
@@ -0,0 +1,18 @@
+class CallToSuspiciousStringMethod {
+
+ void m(String a, String b) {
+ a.