diff --git a/java/java-impl/src/com/intellij/codeInsight/daemon/impl/quickfix/ModifierFix.java b/java/java-impl/src/com/intellij/codeInsight/daemon/impl/quickfix/ModifierFix.java index f3136a75e70a..6ac519e2a2e4 100644 --- a/java/java-impl/src/com/intellij/codeInsight/daemon/impl/quickfix/ModifierFix.java +++ b/java/java-impl/src/com/intellij/codeInsight/daemon/impl/quickfix/ModifierFix.java @@ -118,6 +118,7 @@ public class ModifierFix extends LocalQuickFixAndIntentionActionOnPsiElement { PsiVariable variable = myVariable == null ? null : myVariable.getElement(); boolean isAvailable = BaseIntentionAction.canModify(modifierList) && modifierList.hasExplicitModifier(myModifier) != myShouldHave && + !(variable instanceof SyntheticElement) && (variable == null || variable.isValid()); if (isAvailable && myShowContainingClass && editor != null) { diff --git a/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/modifier14/beforeRecordField.java b/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/modifier14/beforeRecordField.java new file mode 100644 index 000000000000..525149485a31 --- /dev/null +++ b/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/modifier14/beforeRecordField.java @@ -0,0 +1,9 @@ +// "Make 'Point.x' not final" "false" +public record Point(int x, int y, long depth) { + + public Point(int x, int y) { + this(x, y, 10); + this.x = x; + this.y = y; + } +} \ No newline at end of file diff --git a/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/modifier14/beforeRecordField2.java b/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/modifier14/beforeRecordField2.java new file mode 100644 index 000000000000..f65b5381a2a6 --- /dev/null +++ b/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/quickFix/modifier14/beforeRecordField2.java @@ -0,0 +1,7 @@ +// "Make 'Point.x' not final" "false" +public record Point(int x, int y, long depth) { + + public void setX(int x) { + this.x = x; + } +} \ No newline at end of file diff --git a/java/java-tests/testSrc/com/intellij/java/codeInsight/daemon/quickFix/Modifier14Test.java b/java/java-tests/testSrc/com/intellij/java/codeInsight/daemon/quickFix/Modifier14Test.java new file mode 100644 index 000000000000..5eb8cfc0e6ca --- /dev/null +++ b/java/java-tests/testSrc/com/intellij/java/codeInsight/daemon/quickFix/Modifier14Test.java @@ -0,0 +1,34 @@ +/* + * Copyright 2000-2017 JetBrains s.r.o. + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package com.intellij.java.codeInsight.daemon.quickFix; + +import com.intellij.codeInsight.daemon.quickFix.LightQuickFixParameterizedTestCase; +import com.intellij.testFramework.LightProjectDescriptor; +import com.intellij.testFramework.fixtures.LightJavaCodeInsightFixtureTestCase; +import org.jetbrains.annotations.NotNull; + +public class Modifier14Test extends LightQuickFixParameterizedTestCase { + @Override + protected String getBasePath() { + return "/codeInsight/daemonCodeAnalyzer/quickFix/modifier14"; + } + + @NotNull + @Override + protected LightProjectDescriptor getProjectDescriptor() { + return LightJavaCodeInsightFixtureTestCase.JAVA_14; + } +}