From 1cdc186b7011e8ccda16e79d530693b6475cd48e Mon Sep 17 00:00:00 2001 From: Nikolay Chashnikov Date: Mon, 14 Sep 2020 22:55:04 +0300 Subject: [PATCH] [workspace model] don't fire rootsChanged event for changes in global libraries if project isn't opened yet (IDEA-250455) If a global library table is initialized during loading of a project, it doesn't make sense to fire rootsChanged events, and this may lead to exception if loading is performed on a background thread. GitOrigin-RevId: f659ec8bee3935ab453b9d2efd1eaade72514965 --- .../ide/impl/legacyBridge/project/ProjectRootManagerBridge.kt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/platform/lang-impl/src/com/intellij/workspaceModel/ide/impl/legacyBridge/project/ProjectRootManagerBridge.kt b/platform/lang-impl/src/com/intellij/workspaceModel/ide/impl/legacyBridge/project/ProjectRootManagerBridge.kt index bb8bd460c417..0611140665c5 100644 --- a/platform/lang-impl/src/com/intellij/workspaceModel/ide/impl/legacyBridge/project/ProjectRootManagerBridge.kt +++ b/platform/lang-impl/src/com/intellij/workspaceModel/ide/impl/legacyBridge/project/ProjectRootManagerBridge.kt @@ -135,7 +135,9 @@ class ProjectRootManagerBridge(project: Project) : ProjectRootManagerComponent(p } private fun fireRootsChanged() { - makeRootsChange(EmptyRunnable.INSTANCE, false, true) + if (myProject.isOpen) { + makeRootsChange(EmptyRunnable.INSTANCE, false, true) + } } // Listener for global libraries linked to module