From 1c6cda77cca79cb17d04c86fb63effa192c3ecd9 Mon Sep 17 00:00:00 2001 From: Daniil Ovchinnikov Date: Thu, 29 Mar 2018 14:32:39 +0200 Subject: [PATCH] [jvm-lang] get rid of unnecessary overloads in JvmLocalInspection --- .../lang/jvm/inspection/JvmLocalInspection.java | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/java/java-analysis-api/src/com/intellij/lang/jvm/inspection/JvmLocalInspection.java b/java/java-analysis-api/src/com/intellij/lang/jvm/inspection/JvmLocalInspection.java index 0ee404193aa1..e63a74e475a3 100644 --- a/java/java-analysis-api/src/com/intellij/lang/jvm/inspection/JvmLocalInspection.java +++ b/java/java-analysis-api/src/com/intellij/lang/jvm/inspection/JvmLocalInspection.java @@ -29,7 +29,7 @@ public abstract class JvmLocalInspection extends LocalInspectionTool { for (JvmElement jvmElement : JvmDeclarationSearch.getElementsByIdentifier(element)) { if (visitor == null) { // don't build visitor until there is at least one JvmElement - visitor = buildJvmVisitor( + visitor = buildVisitor( holder.getProject(), (message, highlightType, fixes) -> holder.registerProblem(element, message, highlightType, fixes), isOnTheFly @@ -57,12 +57,5 @@ public abstract class JvmLocalInspection extends LocalInspectionTool { } @Nullable - protected JvmElementVisitor buildJvmVisitor(@NotNull Project project, @NotNull HighlightSink sink, boolean isOnTheFly) { - return buildJvmVisitor(project, sink); - } - - @Nullable - protected JvmElementVisitor buildJvmVisitor(@NotNull Project project, @NotNull HighlightSink sink) { - return null; - } + protected abstract JvmElementVisitor buildVisitor(@NotNull Project project, @NotNull HighlightSink sink, boolean isOnTheFly); }