From 1b2f0ba825b0c5802e42fcc93ae0423528d104c8 Mon Sep 17 00:00:00 2001 From: "Maxim.Medvedev" Date: Thu, 10 May 2012 15:04:03 +0400 Subject: [PATCH] 'rename to ignored' fix for unused catch parameters --- .../GroovyUnusedCatchParameterInspection.java | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/plugins/groovy/src/org/jetbrains/plugins/groovy/codeInspection/exception/GroovyUnusedCatchParameterInspection.java b/plugins/groovy/src/org/jetbrains/plugins/groovy/codeInspection/exception/GroovyUnusedCatchParameterInspection.java index 7c6165eaeeab..9747d550e422 100644 --- a/plugins/groovy/src/org/jetbrains/plugins/groovy/codeInspection/exception/GroovyUnusedCatchParameterInspection.java +++ b/plugins/groovy/src/org/jetbrains/plugins/groovy/codeInspection/exception/GroovyUnusedCatchParameterInspection.java @@ -15,9 +15,12 @@ */ package org.jetbrains.plugins.groovy.codeInspection.exception; +import com.intellij.codeInsight.daemon.impl.quickfix.RenameElementFix; +import com.intellij.codeInspection.LocalQuickFix; +import com.intellij.codeInspection.ProblemHighlightType; +import com.intellij.psi.PsiElement; import org.jetbrains.annotations.Nls; import org.jetbrains.annotations.NotNull; -import org.jetbrains.annotations.Nullable; import org.jetbrains.plugins.groovy.codeInspection.BaseInspection; import org.jetbrains.plugins.groovy.codeInspection.BaseInspectionVisitor; import org.jetbrains.plugins.groovy.lang.psi.api.statements.GrCatchClause; @@ -42,12 +45,6 @@ public class GroovyUnusedCatchParameterInspection extends BaseInspection { return "Unused catch parameter"; } - @Nullable - protected String buildErrorString(Object... args) { - return "Unused catch parameter '#ref' #loc"; - - } - public BaseInspectionVisitor buildVisitor() { return new Visitor(); } @@ -71,7 +68,9 @@ public class GroovyUnusedCatchParameterInspection extends BaseInspection { final CatchParameterUsedVisitor visitor = new CatchParameterUsedVisitor(parameter); block.accept(visitor); if (!visitor.isUsed()) { - registerVariableError(parameter); + final PsiElement nameIdentifier = parameter.getNameIdentifierGroovy(); + registerError(nameIdentifier, "Unused catch parameter '#ref' #loc", new LocalQuickFix[]{new RenameElementFix(parameter, "ignored")}, + ProblemHighlightType.GENERIC_ERROR_OR_WARNING); } } }