From 1a70d8bcbd858b032639dd2206f01f8eb1cfe678 Mon Sep 17 00:00:00 2001
From: "Anna.Kozlova" <anna.kozlova@jetbrains.com>
Date: Wed, 4 May 2016 19:45:36 +0200
Subject: [PATCH] push down: apply javadoc settings when keep abstract
 (IDEA-155596)

---
 .../memberPushDown/JavaPushDownDelegate.java  | 37 ++++++++++---------
 .../JavadocWhenKeepAsAbstractClass.java       |  8 ++++
 .../JavadocWhenKeepAsAbstractClass_after.java | 11 ++++++
 .../JavadocWhenKeepAsAbstractInterface.java   |  8 ++++
 ...adocWhenKeepAsAbstractInterface_after.java | 11 ++++++
 .../intellij/refactoring/PushDownTest.java    |  8 ++++
 6 files changed, 66 insertions(+), 17 deletions(-)
 create mode 100644 java/java-tests/testData/refactoring/pushDown/JavadocWhenKeepAsAbstractClass.java
 create mode 100644 java/java-tests/testData/refactoring/pushDown/JavadocWhenKeepAsAbstractClass_after.java
 create mode 100644 java/java-tests/testData/refactoring/pushDown/JavadocWhenKeepAsAbstractInterface.java
 create mode 100644 java/java-tests/testData/refactoring/pushDown/JavadocWhenKeepAsAbstractInterface_after.java

diff --git a/java/java-impl/src/com/intellij/refactoring/memberPushDown/JavaPushDownDelegate.java b/java/java-impl/src/com/intellij/refactoring/memberPushDown/JavaPushDownDelegate.java
index 283ff8963e1f..ac29992e1116 100644
--- a/java/java-impl/src/com/intellij/refactoring/memberPushDown/JavaPushDownDelegate.java
+++ b/java/java-impl/src/com/intellij/refactoring/memberPushDown/JavaPushDownDelegate.java
@@ -217,27 +217,30 @@ public class JavaPushDownDelegate extends PushDownDelegate<MemberInfo, PsiMember
         PsiMethod methodBySignature = MethodSignatureUtil.findMethodBySuperSignature(targetClass, method.getSignature(substitutor), false);
         if (methodBySignature == null) {
           newMember = (PsiMethod)targetClass.add(method);
-          if (sourceClass.isInterface()) {
-            final PsiMethod oldMethod = (PsiMethod)memberInfo.getMember();
-            if (!targetClass.isInterface()) {
-              PsiUtil.setModifierProperty(newMember, PsiModifier.PUBLIC, true);
-              if (oldMethod.hasModifierProperty(PsiModifier.ABSTRACT)) {
-                RefactoringUtil.makeMethodAbstract(targetClass, (PsiMethod)newMember);
+          final PsiMethod oldMethod = (PsiMethod)memberInfo.getMember();
+          if (sourceClass.isInterface() && !targetClass.isInterface()) {
+            PsiUtil.setModifierProperty(newMember, PsiModifier.PUBLIC, true);
+            if (oldMethod.hasModifierProperty(PsiModifier.ABSTRACT)) {
+              RefactoringUtil.makeMethodAbstract(targetClass, (PsiMethod)newMember);
+            }
+            else {
+              PsiUtil.setModifierProperty(newMember, PsiModifier.DEFAULT, false);
+            }
+          }
+
+          if (memberInfo.isToAbstract()) {
+            if (sourceClass.isInterface()) {
+              if (oldMethod.hasModifierProperty(PsiModifier.DEFAULT)) {
+                PsiUtil.setModifierProperty(oldMethod, PsiModifier.DEFAULT, false);
+                RefactoringUtil.makeMethodAbstract(sourceClass, oldMethod);
               }
-              else {
-                PsiUtil.setModifierProperty(newMember, PsiModifier.DEFAULT, false);
+            }
+            else {
+              if (newMember.hasModifierProperty(PsiModifier.PRIVATE)) {
+                PsiUtil.setModifierProperty(newMember, PsiModifier.PROTECTED, true);
               }
             }
 
-            if (memberInfo.isToAbstract() && oldMethod.hasModifierProperty(PsiModifier.DEFAULT)) {
-              PsiUtil.setModifierProperty(oldMethod, PsiModifier.DEFAULT, false);
-              RefactoringUtil.makeMethodAbstract(sourceClass, oldMethod);
-            }
-          }
-          else if (memberInfo.isToAbstract()) {
-            if (newMember.hasModifierProperty(PsiModifier.PRIVATE)) {
-              PsiUtil.setModifierProperty(newMember, PsiModifier.PROTECTED, true);
-            }
             pushDownData.getCommentPolicy().processNewJavaDoc(((PsiMethod)newMember).getDocComment());
           }
           if (memberInfo.isToAbstract()) {
diff --git a/java/java-tests/testData/refactoring/pushDown/JavadocWhenKeepAsAbstractClass.java b/java/java-tests/testData/refactoring/pushDown/JavadocWhenKeepAsAbstractClass.java
new file mode 100644
index 000000000000..32325db34872
--- /dev/null
+++ b/java/java-tests/testData/refactoring/pushDown/JavadocWhenKeepAsAbstractClass.java
@@ -0,0 +1,8 @@
+abstract class Test {
+  /**
+   * foo's javadoc
+   */
+  abstract void foo();
+}
+
+abstract class B extends Test {}
\ No newline at end of file
diff --git a/java/java-tests/testData/refactoring/pushDown/JavadocWhenKeepAsAbstractClass_after.java b/java/java-tests/testData/refactoring/pushDown/JavadocWhenKeepAsAbstractClass_after.java
new file mode 100644
index 000000000000..55cce0d3edc6
--- /dev/null
+++ b/java/java-tests/testData/refactoring/pushDown/JavadocWhenKeepAsAbstractClass_after.java
@@ -0,0 +1,11 @@
+abstract class Test {
+  /**
+   * foo's javadoc
+   */
+  abstract void foo();
+}
+
+abstract class B extends Test {
+    @Override
+    abstract void foo();
+}
\ No newline at end of file
diff --git a/java/java-tests/testData/refactoring/pushDown/JavadocWhenKeepAsAbstractInterface.java b/java/java-tests/testData/refactoring/pushDown/JavadocWhenKeepAsAbstractInterface.java
new file mode 100644
index 000000000000..28c4029f9d93
--- /dev/null
+++ b/java/java-tests/testData/refactoring/pushDown/JavadocWhenKeepAsAbstractInterface.java
@@ -0,0 +1,8 @@
+interface Test {
+  /**
+   * foo's javadoc
+   */
+  void foo();
+}
+
+interface B extends Test {}
\ No newline at end of file
diff --git a/java/java-tests/testData/refactoring/pushDown/JavadocWhenKeepAsAbstractInterface_after.java b/java/java-tests/testData/refactoring/pushDown/JavadocWhenKeepAsAbstractInterface_after.java
new file mode 100644
index 000000000000..51c58e13503b
--- /dev/null
+++ b/java/java-tests/testData/refactoring/pushDown/JavadocWhenKeepAsAbstractInterface_after.java
@@ -0,0 +1,11 @@
+interface Test {
+  /**
+   * foo's javadoc
+   */
+  void foo();
+}
+
+interface B extends Test {
+    @Override
+    void foo();
+}
\ No newline at end of file
diff --git a/java/java-tests/testSrc/com/intellij/refactoring/PushDownTest.java b/java/java-tests/testSrc/com/intellij/refactoring/PushDownTest.java
index 0aa5fe9e93e6..5084773e67b5 100644
--- a/java/java-tests/testSrc/com/intellij/refactoring/PushDownTest.java
+++ b/java/java-tests/testSrc/com/intellij/refactoring/PushDownTest.java
@@ -87,6 +87,14 @@ public class PushDownTest extends LightRefactoringTestCase {
     doTest(true);
   }
 
+  public void testJavadocWhenKeepAsAbstractInterface() throws Exception {
+    doTestImplements(true);
+  }
+
+  public void testJavadocWhenKeepAsAbstractClass() throws Exception {
+    doTestImplements(true);
+  }
+
   private void doTest() {
     doTest(false);
   }