From 1933912ec4a9f37e9c0ef70259a638baba19437d Mon Sep 17 00:00:00 2001
From: Vladimir Krivosheev <vladimir.krivosheev@jetbrains.com>
Date: Sun, 23 Apr 2017 09:24:54 +0200
Subject: [PATCH] IDEA-CR-20496 RunConfigurationBeforeRunProvider now is called
 for temp RC, so, we must avoid `init` call

---
 .../execution/impl/RunConfigurationBeforeRunProvider.java    | 5 +++++
 .../src/com/intellij/execution/impl/RunManagerImpl.kt        | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/platform/lang-impl/src/com/intellij/execution/impl/RunConfigurationBeforeRunProvider.java b/platform/lang-impl/src/com/intellij/execution/impl/RunConfigurationBeforeRunProvider.java
index d8112243eb87..5ac64598769b 100644
--- a/platform/lang-impl/src/com/intellij/execution/impl/RunConfigurationBeforeRunProvider.java
+++ b/platform/lang-impl/src/com/intellij/execution/impl/RunConfigurationBeforeRunProvider.java
@@ -319,6 +319,11 @@ extends BeforeRunTaskProvider<RunConfigurationBeforeRunProvider.RunConfigurableB
       myConfigurationType = configurationTypeAttr != null ? configurationTypeAttr.getValue() : null;
     }
 
+    // avoid RunManagerImpl.getInstanceImpl and findConfigurationByTypeAndName calls (can be called during RunManagerImpl initialization)
+    boolean isMySettings(@NotNull RunnerAndConfigurationSettings settings) {
+      return settings.getType().getId().equals(myConfigurationType) && settings.getName().equals(myConfigurationName);
+    }
+
     void init() {
       if (myInitialized) {
         return;
diff --git a/platform/lang-impl/src/com/intellij/execution/impl/RunManagerImpl.kt b/platform/lang-impl/src/com/intellij/execution/impl/RunManagerImpl.kt
index fed308d5c560..d508f8610d59 100644
--- a/platform/lang-impl/src/com/intellij/execution/impl/RunManagerImpl.kt
+++ b/platform/lang-impl/src/com/intellij/execution/impl/RunManagerImpl.kt
@@ -1118,7 +1118,7 @@ open class RunManagerImpl(internal val project: Project) : RunManagerEx(), Persi
           val newList = otherConfiguration.beforeRunTasks.nullize()?.toMutableSmartList() ?: continue
           val beforeRunTaskIterator = newList.iterator()
           for (task in beforeRunTaskIterator) {
-            if (task is RunConfigurationBeforeRunProvider.RunConfigurableBeforeRunTask && toRemove.contains(task.settings)) {
+            if (task is RunConfigurationBeforeRunProvider.RunConfigurableBeforeRunTask && toRemove.firstOrNull { task.isMySettings(it) } != null) {
               beforeRunTaskIterator.remove()
               isChanged = true
               changedSettings.add(settings)