From 18fdfcafcc0e77e397299fec3fe8f0d7471c32b8 Mon Sep 17 00:00:00 2001 From: Julia Beliaeva Date: Wed, 14 Jun 2017 17:14:30 +0300 Subject: [PATCH] [git] extract method for creating log config parameters --- .../git4idea/src/git4idea/history/GitLogUtil.java | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/plugins/git4idea/src/git4idea/history/GitLogUtil.java b/plugins/git4idea/src/git4idea/history/GitLogUtil.java index 2b85f1bcfadb..dd41a1f7de4a 100644 --- a/plugins/git4idea/src/git4idea/history/GitLogUtil.java +++ b/plugins/git4idea/src/git4idea/history/GitLogUtil.java @@ -265,9 +265,7 @@ public class GitLogUtil { boolean withChanges, @NotNull Consumer converter, String... parameters) throws VcsException { - List configParameters = Registry.is("git.diff.renameLimit.infinity") && withChanges ? - Collections.singletonList("diff.renameLimit=0") : Collections.emptyList(); - GitLineHandler handler = new GitLineHandler(project, root, GitCommand.LOG, configParameters); + GitLineHandler handler = new GitLineHandler(project, root, GitCommand.LOG, createConfigParameters(withChanges)); readRecordsFromHandler(project, root, withRefs, withChanges, converter, handler, parameters); } @@ -356,9 +354,7 @@ public class GitLogUtil { commitConsumer.consume(createCommit(project, root, records, factory)); } }; - List configParameters = Registry.is("git.diff.renameLimit.infinity") ? - Collections.singletonList("diff.renameLimit=0") : Collections.emptyList(); - GitLineHandler handler = new GitLineHandler(project, root, GitCommand.LOG, configParameters); + GitLineHandler handler = new GitLineHandler(project, root, GitCommand.LOG, createConfigParameters(true)); Ref inputError = new Ref<>(); handler.setInputProcessor(stream -> { @@ -384,4 +380,10 @@ public class GitLogUtil { throw new VcsException(inputError.get()); } } + + @NotNull + private static List createConfigParameters(boolean withChanges) { + return Registry.is("git.diff.renameLimit.infinity") && withChanges ? + Collections.singletonList("diff.renameLimit=0") : Collections.emptyList(); + } }