From 18b7dbfcb25e7d43d35355ea1e31be96a7a7806a Mon Sep 17 00:00:00 2001 From: Vladimir Krivosheev Date: Thu, 19 Feb 2015 16:10:11 +0100 Subject: [PATCH] cleanup --- .../src/com/intellij/openapi/util/JDOMExternalizer.java | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/platform/util/src/com/intellij/openapi/util/JDOMExternalizer.java b/platform/util/src/com/intellij/openapi/util/JDOMExternalizer.java index baf878554b4b..eb436efb1226 100644 --- a/platform/util/src/com/intellij/openapi/util/JDOMExternalizer.java +++ b/platform/util/src/com/intellij/openapi/util/JDOMExternalizer.java @@ -51,15 +51,13 @@ public class JDOMExternalizer { } public static int readInteger(Element root, String name, int defaultValue) { - String v = readString(root, name); - return v == null ? defaultValue : StringUtilRt.parseInt(v, defaultValue); + return StringUtilRt.parseInt(readString(root, name), defaultValue); } @Nullable public static String readString(@NonNls Element root, @NonNls String name) { for (Element element : root.getChildren("setting")) { - String childName = element.getAttributeValue("name"); - if (Comparing.strEqual(childName, name)) { + if (Comparing.strEqual(element.getAttributeValue("name"), name)) { return element.getAttributeValue("value"); } }