diff --git a/platform/analysis-impl/src/com/intellij/codeInspection/ex/HTMLComposerImpl.java b/platform/analysis-impl/src/com/intellij/codeInspection/ex/HTMLComposerImpl.java index 3a2fc42b6185..23cb2e2e0c27 100644 --- a/platform/analysis-impl/src/com/intellij/codeInspection/ex/HTMLComposerImpl.java +++ b/platform/analysis-impl/src/com/intellij/codeInspection/ex/HTMLComposerImpl.java @@ -24,8 +24,6 @@ import java.util.HashMap; import java.util.Map; public abstract class HTMLComposerImpl extends HTMLComposer { - private final int[] myListStack; - private int myListStackTop; private final Map myExtensions = new HashMap<>(); private final Map myLanguageExtensions = new HashMap<>(); protected static final @NonNls String BR = "
"; @@ -40,8 +38,6 @@ public abstract class HTMLComposerImpl extends HTMLComposer { public static final @NonNls String A_CLOSING = ""; protected HTMLComposerImpl() { - myListStack = new int[5]; - myListStackTop = -1; for (InspectionExtensionsFactory factory : InspectionExtensionsFactory.EP_NAME.getExtensionList()) { final HTMLComposerExtension extension = factory.createHTMLComposerExtension(this); if (extension != null) { @@ -179,11 +175,8 @@ public abstract class HTMLComposerImpl extends HTMLComposer { if (extension != null) { extension.appendReferencePresentation(refElement, buf, isPackageIncluded); } else if (refElement instanceof RefFile || refElement instanceof RefDirectory) { - buf.append(A_HREF_OPENING); + buf.append(A_HREF_OPENING).append(((RefElementImpl)refElement).getURL()).append("\">"); - buf.append(((RefElementImpl)refElement).getURL()); - - buf.append("\">"); String refElementName = refElement.getName(); final PsiElement element = refElement.getPsiElement(); if (element != null) { @@ -215,7 +208,7 @@ public abstract class HTMLComposerImpl extends HTMLComposer { @Override public void appendElementInReferences(@NotNull StringBuilder buf, RefElement refElement) { - if (refElement.getInReferences().size() > 0) { + if (!refElement.getInReferences().isEmpty()) { appendHeading(buf, AnalysisBundle.message("inspection.export.results.used.from")); startList(buf); for (RefElement refCaller : refElement.getInReferences()) { @@ -227,7 +220,7 @@ public abstract class HTMLComposerImpl extends HTMLComposer { @Override public void appendElementOutReferences(@NotNull StringBuilder buf, RefElement refElement) { - if (refElement.getOutReferences().size() > 0) { + if (!refElement.getOutReferences().isEmpty()) { appendHeading(buf, AnalysisBundle.message("inspection.export.results.uses")); startList(buf); for (RefElement refCallee : refElement.getOutReferences()) { @@ -271,38 +264,22 @@ public abstract class HTMLComposerImpl extends HTMLComposer { } } - @Override public void startList(@NotNull StringBuilder buf) { - if (myListStackTop == -1) { - buf.append("
"); - } - buf.append("
    "); - myListStackTop++; - myListStack[myListStackTop] = 0; + buf.append("\n
      "); } @Override public void doneList(@NotNull StringBuilder buf) { - buf.append("
    "); - if (myListStack[myListStackTop] != 0) { - buf.append("
     
    "); - } - if (myListStackTop == 0) { - buf.append("
"); - } - myListStackTop--; + buf.append("\n"); } @Override public void startListItem(@NotNull StringBuilder buf) { - myListStack[myListStackTop]++; - buf.append("
  • "); + buf.append("\n
  • "); } - public static void doneListItem(@NotNull StringBuilder buf) { - buf.append("
  • "); - } + public static void doneListItem(@NotNull StringBuilder buf) {} @Override public void appendNoProblems(@NotNull StringBuilder buf) { diff --git a/platform/lang-impl/src/com/intellij/codeInspection/ex/DescriptorComposer.java b/platform/lang-impl/src/com/intellij/codeInspection/ex/DescriptorComposer.java index 58c70ebd5fda..b83606065abf 100644 --- a/platform/lang-impl/src/com/intellij/codeInspection/ex/DescriptorComposer.java +++ b/platform/lang-impl/src/com/intellij/codeInspection/ex/DescriptorComposer.java @@ -44,12 +44,14 @@ public final class DescriptorComposer extends HTMLComposerImpl { LOG.assertTrue(descriptions != null); - buf.append("\n\n"); + doneList(buf); + buf.append("\n"); appendResolution(buf, refEntity, quickFixTexts(refEntity, myTool)); }