From 15bb7ce510a86ac95a63e67ec407e4c0c8cb7866 Mon Sep 17 00:00:00 2001
From: Eugene Zhuravlev <jeka@intellij.com>
Date: Mon, 4 Jul 2016 13:55:10 +0200
Subject: [PATCH] Clear channel attributes on channel unregister to avoid
 project leaks (IDEA-158108)

---
 .../intellij/compiler/server/BuildMessageDispatcher.java | 9 ++++++++-
 .../org/jetbrains/jps/javac/ExternalJavacManager.java    | 2 +-
 2 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/java/compiler/impl/src/com/intellij/compiler/server/BuildMessageDispatcher.java b/java/compiler/impl/src/com/intellij/compiler/server/BuildMessageDispatcher.java
index 2624cde1af17..ed3bbba1709c 100644
--- a/java/compiler/impl/src/com/intellij/compiler/server/BuildMessageDispatcher.java
+++ b/java/compiler/impl/src/com/intellij/compiler/server/BuildMessageDispatcher.java
@@ -71,7 +71,14 @@ class BuildMessageDispatcher extends SimpleChannelInboundHandlerAdapter<CmdlineR
   public BuilderMessageHandler unregisterBuildMessageHandler(UUID sessionId) {
     myCanceledSessions.remove(sessionId);
     final SessionData data = mySessionDescriptors.remove(sessionId);
-    return data != null? data.handler : null;
+    if (data == null) {
+      return null;
+    }
+    final Channel channel = data.channel;
+    if (channel != null) {
+      channel.attr(SESSION_DATA).remove(); // cleanup the attribute so that session data is not leaked
+    }
+    return data.handler;
   }
 
   public void cancelSession(UUID sessionId) {
diff --git a/jps/jps-builders/src/org/jetbrains/jps/javac/ExternalJavacManager.java b/jps/jps-builders/src/org/jetbrains/jps/javac/ExternalJavacManager.java
index bcb413016a94..4723457fcca6 100644
--- a/jps/jps-builders/src/org/jetbrains/jps/javac/ExternalJavacManager.java
+++ b/jps/jps-builders/src/org/jetbrains/jps/javac/ExternalJavacManager.java
@@ -326,7 +326,7 @@ public class ExternalJavacManager {
   private class CompilationRequestsHandler extends SimpleChannelInboundHandler<JavacRemoteProto.Message> {
     @Override
     public void channelUnregistered(ChannelHandlerContext ctx) throws Exception {
-      JavacProcessDescriptor descriptor = ctx.channel().attr(SESSION_DESCRIPTOR).get();
+      JavacProcessDescriptor descriptor = ctx.channel().attr(SESSION_DESCRIPTOR).getAndRemove();
       if (descriptor != null) {
         descriptor.setDone();
       }