From 15809e6ed11f8c792201e60bb1f4bf1961934fa4 Mon Sep 17 00:00:00 2001 From: "Ilya.Kazakevich" Date: Fri, 19 Dec 2025 01:59:25 +0100 Subject: [PATCH] cleanup [python]: Use `trace` instead of `debug` in python sorting logic. it is semantically `trace`. GitOrigin-RevId: 8cb140d22ecbabdb74b3764174538067109eda0f --- .../python/community/services/shared/comparators.kt | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/python/services/shared/src/com/intellij/python/community/services/shared/comparators.kt b/python/services/shared/src/com/intellij/python/community/services/shared/comparators.kt index aef5e105e1bc..501e8ec6127e 100644 --- a/python/services/shared/src/com/intellij/python/community/services/shared/comparators.kt +++ b/python/services/shared/src/com/intellij/python/community/services/shared/comparators.kt @@ -10,8 +10,8 @@ private val logger = fileLogger() object UiComparator : Comparator { override fun compare(o1: UiHolder, o2: UiHolder): Int { - if (logger.isDebugEnabled) { - logger.debug("ui ${o1.ui?.toolName} vs ${o2.ui?.toolName}") + if (logger.isTraceEnabled) { + logger.trace("ui ${o1.ui?.toolName} vs ${o2.ui?.toolName}") } return Objects.compare(o1.ui, o2.ui, Comparator.nullsFirst(PyToolUIInfo::compareTo)) } @@ -20,8 +20,8 @@ object UiComparator : Comparator { object PythonInfoComparator : Comparator { override fun compare(o1: PythonInfoHolder, o2: PythonInfoHolder): Int { // Backward: first python is the highest - if (logger.isDebugEnabled) { - logger.debug("pythonInfo ${o1.pythonInfo} vs ${o2.pythonInfo}") + if (logger.isTraceEnabled) { + logger.trace("pythonInfo ${o1.pythonInfo} vs ${o2.pythonInfo}") } return o1.pythonInfo.compareTo(o2.pythonInfo) } @@ -29,8 +29,8 @@ object PythonInfoComparator : Comparator { class PythonInfoWithUiComparator : Comparator where T : PythonInfoHolder, T : UiHolder { override fun compare(o1: T, o2: T): Int { - if (logger.isDebugEnabled) { - logger.debug("full ${o1.string()} vs ${o2.string()}") + if (logger.isTraceEnabled) { + logger.trace("full ${o1.string()} vs ${o2.string()}") } return PythonInfoComparator.compare(o1, o2) * 10 + UiComparator.compare(o1, o2) }