From 154e3efd043cbdfdcc2f777d10b3fcbae2a81c4c Mon Sep 17 00:00:00 2001 From: Dana Dahlstrom Date: Tue, 6 Dec 2016 20:42:48 +0300 Subject: [PATCH] Test Hash comparisons using assertThat which makes failure messages and assertion code more readable, and avoids http://errorprone.info/bugpattern/SelfEquals. --- .../com/intellij/vcs/log/impl/HashEqualsTest.java | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/platform/vcs-log/impl/test/com/intellij/vcs/log/impl/HashEqualsTest.java b/platform/vcs-log/impl/test/com/intellij/vcs/log/impl/HashEqualsTest.java index 3d368becc5a9..a6fd12022724 100644 --- a/platform/vcs-log/impl/test/com/intellij/vcs/log/impl/HashEqualsTest.java +++ b/platform/vcs-log/impl/test/com/intellij/vcs/log/impl/HashEqualsTest.java @@ -18,7 +18,7 @@ package com.intellij.vcs.log.impl; import com.intellij.vcs.log.Hash; import org.junit.Test; -import static org.junit.Assert.*; +import static org.assertj.core.api.Assertions.assertThat; /** * @author erokhins @@ -27,27 +27,26 @@ public class HashEqualsTest { @Test public void testEqualsSelf() { Hash hash = HashImpl.build("adf"); - //noinspection EqualsWithItself - assertTrue(hash.equals(hash)); + assertThat(hash).isEqualTo(hash); } @Test public void testEqualsNull() { Hash hash = HashImpl.build("adf"); - assertFalse(hash.equals(null)); + assertThat(hash).isNotNull(); } @Test public void testEquals() { Hash hash1 = HashImpl.build("adf"); Hash hash2 = HashImpl.build("adf"); - assertTrue(hash1.equals(hash2)); + assertThat(hash1).isEqualTo(hash2); } @Test public void testEqualsNone() { Hash hash1 = HashImpl.build(""); Hash hash2 = HashImpl.build(""); - assertTrue(hash1.equals(hash2)); + assertThat(hash1).isEqualTo(hash2); } }