From 10ec8198a8d17ea326637b37745b4d500d1b7b80 Mon Sep 17 00:00:00 2001
From: Vladimir Krivosheev <vladimir.krivosheev@jetbrains.com>
Date: Wed, 12 Dec 2018 20:38:11 +0100
Subject: [PATCH] =?UTF-8?q?IDEA-CR-41226=20IDEA-204001=20don't=20update=20?=
 =?UTF-8?q?state=20on=20appClosing=20=E2=80=94=20projectClosed=20(fixed=20?=
 =?UTF-8?q?in=20this=20commit)=20and=20projectOpened=20(earlier=20commit)?=
 =?UTF-8?q?=20is=20more=20correct?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .../intellij/ide/RecentProjectsManagerBase.java  | 16 ++++------------
 1 file changed, 4 insertions(+), 12 deletions(-)

diff --git a/platform/platform-impl/src/com/intellij/ide/RecentProjectsManagerBase.java b/platform/platform-impl/src/com/intellij/ide/RecentProjectsManagerBase.java
index 0feb788e3682..22f5b35c21c5 100644
--- a/platform/platform-impl/src/com/intellij/ide/RecentProjectsManagerBase.java
+++ b/platform/platform-impl/src/com/intellij/ide/RecentProjectsManagerBase.java
@@ -192,7 +192,7 @@ public class RecentProjectsManagerBase extends RecentProjectsManager implements
       }
 
       // it is not good to have timestamps in state data, anyway, now state saved not on "timer" (not more than once in 5 minutes),
-      // but if modification counter changed (that's why updateOpenProjectsTimestamps is not called in getModificationCounter as validateRecentProjects)
+      // but if modification counter changed
       myState.updateOpenProjectsTimestamps(this);
       return myState;
     }
@@ -307,8 +307,10 @@ public class RecentProjectsManagerBase extends RecentProjectsManager implements
           }
         }
       }
+      myState.validateRecentProjects(myModCounter);
     }
 
+    // for simplicity, for now just increment and don't check is something really changed
     myModCounter.incrementAndGet();
   }
 
@@ -652,6 +654,7 @@ public class RecentProjectsManagerBase extends RecentProjectsManager implements
           markPathRecent(path, openProject);
         }
       }
+      updateLastProjectPath();
       updateUI();
     }
   }
@@ -757,7 +760,6 @@ public class RecentProjectsManagerBase extends RecentProjectsManager implements
 
   @Override
   public long getModificationCount() {
-    myState.validateRecentProjects(myModCounter);
     return myModCounter.get();
   }
 
@@ -778,20 +780,10 @@ public class RecentProjectsManagerBase extends RecentProjectsManager implements
       doReopenLastProject();
     }
 
-    @Override
-    public void projectFrameClosed() {
-      updateLastProjectPath();
-    }
-
     @Override
     public void projectOpenFailed() {
       updateLastProjectPath();
     }
-
-    @Override
-    public void appClosing() {
-      updateLastProjectPath();
-    }
   }
 
   private static class MyIcon extends Pair<Icon, Long> {