diff --git a/platform/editor-ui-api/src/com/intellij/ide/ui/UISettings.kt b/platform/editor-ui-api/src/com/intellij/ide/ui/UISettings.kt index da9ee0741018..26d417520f0d 100644 --- a/platform/editor-ui-api/src/com/intellij/ide/ui/UISettings.kt +++ b/platform/editor-ui-api/src/com/intellij/ide/ui/UISettings.kt @@ -221,14 +221,20 @@ class UISettings(private val notRoamableOptions: NotRoamableUiSettings) : Persis state.wideScreenSupport = value } - val sortBookmarks: Boolean + var sortBookmarks: Boolean get() = state.sortBookmarks + set(value) { + state.sortBookmarks = value + } val showCloseButton: Boolean get() = state.showCloseButton - val presentationMode: Boolean + var presentationMode: Boolean get() = state.presentationMode + set(value) { + state.presentationMode = value + } val presentationModeFontSize: Int get() = state.presentationModeFontSize @@ -287,6 +293,24 @@ class UISettings(private val notRoamableOptions: NotRoamableUiSettings) : Persis state.pinFindInPath = value } + var activeRightEditorOnClose: Boolean + get() = state.activeRightEditorOnClose + set(value) { + state.activeRightEditorOnClose = value + } + + var showTabsTooltips: Boolean + get() = state.showTabsTooltips + set(value) { + state.showTabsTooltips = value + } + + var markModifiedTabsWithAsterisk: Boolean + get() = state.markModifiedTabsWithAsterisk + set(value) { + state.markModifiedTabsWithAsterisk = value + } + @Suppress("unused") var overrideConsoleCycleBufferSize: Boolean get() = state.overrideConsoleCycleBufferSize diff --git a/platform/lang-impl/src/com/intellij/application/options/editor/EditorAppearanceConfigurable.java b/platform/lang-impl/src/com/intellij/application/options/editor/EditorAppearanceConfigurable.java index 11ff364b8c53..6b93133f4978 100644 --- a/platform/lang-impl/src/com/intellij/application/options/editor/EditorAppearanceConfigurable.java +++ b/platform/lang-impl/src/com/intellij/application/options/editor/EditorAppearanceConfigurable.java @@ -115,7 +115,7 @@ public class EditorAppearanceConfigurable extends CompositeConfigurable= max; i--) { myData.remove(i); } diff --git a/platform/platform-impl/src/com/intellij/ide/actions/TogglePresentationModeAction.java b/platform/platform-impl/src/com/intellij/ide/actions/TogglePresentationModeAction.java index 23e3378fc2b4..c75e92653cc7 100644 --- a/platform/platform-impl/src/com/intellij/ide/actions/TogglePresentationModeAction.java +++ b/platform/platform-impl/src/com/intellij/ide/actions/TogglePresentationModeAction.java @@ -62,7 +62,7 @@ public class TogglePresentationModeAction extends AnAction implements DumbAware public static void setPresentationMode(final Project project, final boolean inPresentation) { final UISettings settings = UISettings.getInstance(); - settings.getState().setPresentationMode(inPresentation); + settings.setPresentationMode(inPresentation); final boolean layoutStored = storeToolWindows(project); diff --git a/platform/platform-impl/src/com/intellij/openapi/editor/impl/EditorMarkupModelImpl.java b/platform/platform-impl/src/com/intellij/openapi/editor/impl/EditorMarkupModelImpl.java index 034b7a78e433..4d12f16128fd 100644 --- a/platform/platform-impl/src/com/intellij/openapi/editor/impl/EditorMarkupModelImpl.java +++ b/platform/platform-impl/src/com/intellij/openapi/editor/impl/EditorMarkupModelImpl.java @@ -182,7 +182,7 @@ public class EditorMarkupModelImpl extends MarkupModelImpl implements EditorMark int visualY = myEditor.getLineHeight() * visualLine; boolean isVisible = myWheelAccumulator == 0 && area.contains(area.x, visualY); - if (UIUtil.uiParents(myEditor.getComponent(), false).filter(EditorWindowHolder.class).isEmpty() || isVisible || !UISettings.getInstance().getState().getShowEditorToolTip()) { + if (UIUtil.uiParents(myEditor.getComponent(), false).filter(EditorWindowHolder.class).isEmpty() || isVisible || !UISettings.getInstance().getShowEditorToolTip()) { final Set highlighters = new THashSet<>(); getNearestHighlighters(this, me.getY(), highlighters); getNearestHighlighters(((EditorEx)getEditor()).getFilteredDocumentMarkupModel(), me.getY(), highlighters); @@ -527,7 +527,7 @@ public class EditorMarkupModelImpl extends MarkupModelImpl implements EditorMark @Override public void uiSettingsChanged(UISettings uiSettings) { - if (!uiSettings.getState().getShowEditorToolTip()) { + if (!uiSettings.getShowEditorToolTip()) { hideMyEditorPreviewHint(); } setMinMarkHeight(DaemonCodeAnalyzerSettings.getInstance().getErrorStripeMarkMinHeight()); diff --git a/platform/platform-impl/src/com/intellij/openapi/fileEditor/impl/EditorWindow.java b/platform/platform-impl/src/com/intellij/openapi/fileEditor/impl/EditorWindow.java index 20a8a73d629e..3bbc2bbaeb5b 100644 --- a/platform/platform-impl/src/com/intellij/openapi/fileEditor/impl/EditorWindow.java +++ b/platform/platform-impl/src/com/intellij/openapi/fileEditor/impl/EditorWindow.java @@ -4,6 +4,7 @@ package com.intellij.openapi.fileEditor.impl; import com.intellij.icons.AllIcons; import com.intellij.ide.actions.CloseAction; import com.intellij.ide.ui.UISettings; +import com.intellij.ide.ui.UISettingsState; import com.intellij.openapi.actionSystem.CommonDataKeys; import com.intellij.openapi.actionSystem.DataKey; import com.intellij.openapi.actionSystem.DataProvider; @@ -98,7 +99,7 @@ public class EditorWindow { private final Stack> myRemovedTabs = new Stack>() { @Override public void push(Pair pair) { - if (size() >= UISettings.getInstance().getState().getEditorTabLimit()) { + if (size() >= UISettings.getInstance().getEditorTabLimit()) { remove(0); } super.push(pair); @@ -335,8 +336,8 @@ public class EditorWindow { // if the file being closed is not currently selected, keep the currently selected file open return currentlySelectedIndex; } - UISettings uiSettings = UISettings.getInstance(); - if (uiSettings.getState().getActiveMruEditorOnClose()) { + UISettingsState uiSettings = UISettings.getInstance().getState(); + if (uiSettings.getActiveMruEditorOnClose()) { // try to open last visited file final List histFiles = EditorHistoryManager.getInstance(getManager ().getProject()).getFileList(); for (int idx = histFiles.size() - 1; idx >= 0; idx--) { @@ -355,7 +356,7 @@ public class EditorWindow { } } } else - if (uiSettings.getState().getActiveRightEditorOnClose() && fileIndex + 1 < myTabbedPane.getTabCount()) { + if (uiSettings.getActiveRightEditorOnClose() && fileIndex + 1 < myTabbedPane.getTabCount()) { return fileIndex + 1; } @@ -716,7 +717,7 @@ public class EditorWindow { final VirtualFile file = editor.getFile(); final Icon template = AllIcons.FileTypes.Text; myTabbedPane.insertTab(file, EmptyIcon.create(template.getIconWidth(), template.getIconHeight()), new TComp(this, editor), null, indexToInsert); - trimToSize(UISettings.getInstance().getState().getEditorTabLimit(), file, false); + trimToSize(UISettings.getInstance().getEditorTabLimit(), file, false); if (selectEditor) { setSelectedEditor(editor, focusEditor); } @@ -901,7 +902,7 @@ public class EditorWindow { final int index = findEditorIndex(findFileComposite(file)); if (index != -1) { setTitleAt(index, EditorTabPresentationUtil.getEditorTabTitle(getManager().getProject(), file, this)); - setToolTipTextAt(index, UISettings.getInstance().getState().getShowTabsTooltips() + setToolTipTextAt(index, UISettings.getInstance().getShowTabsTooltips() ? getManager().getFileTooltipText(file) : null); } @@ -933,9 +934,8 @@ public class EditorWindow { final Icon modifiedIcon; UISettings settings = UISettings.getInstance(); - if (settings.getState().getMarkModifiedTabsWithAsterisk() || !settings.getHideTabsIfNeed()) { - modifiedIcon = - settings.getState().getMarkModifiedTabsWithAsterisk() && composite != null && composite.isModified() ? MODIFIED_ICON : GAP_ICON; + if (settings.getMarkModifiedTabsWithAsterisk() || !settings.getHideTabsIfNeed()) { + modifiedIcon = settings.getMarkModifiedTabsWithAsterisk() && composite != null && composite.isModified() ? MODIFIED_ICON : GAP_ICON; count++; } else { diff --git a/platform/platform-impl/src/com/intellij/openapi/fileEditor/impl/EditorsSplitters.java b/platform/platform-impl/src/com/intellij/openapi/fileEditor/impl/EditorsSplitters.java index 4f47fdbf03eb..94c7123c9f5d 100644 --- a/platform/platform-impl/src/com/intellij/openapi/fileEditor/impl/EditorsSplitters.java +++ b/platform/platform-impl/src/com/intellij/openapi/fileEditor/impl/EditorsSplitters.java @@ -797,7 +797,7 @@ public class EditorsSplitters extends IdePanePanel implements UISettingsListener final List children = new ArrayList<>(fileElements.size()); // trim to EDITOR_TAB_LIMIT, ignoring CLOSE_NON_MODIFIED_FILES_FIRST policy - int toRemove = fileElements.size() - UISettings.getInstance().getState().getEditorTabLimit(); + int toRemove = fileElements.size() - UISettings.getInstance().getEditorTabLimit(); for (Element fileElement : fileElements) { if (toRemove <= 0 || Boolean.valueOf(fileElement.getAttributeValue(PINNED)).booleanValue()) { children.add(fileElement); diff --git a/platform/platform-impl/src/com/intellij/openapi/wm/impl/ToolWindowsPane.java b/platform/platform-impl/src/com/intellij/openapi/wm/impl/ToolWindowsPane.java index 228f4b919d7b..d7aab67dda23 100644 --- a/platform/platform-impl/src/com/intellij/openapi/wm/impl/ToolWindowsPane.java +++ b/platform/platform-impl/src/com/intellij/openapi/wm/impl/ToolWindowsPane.java @@ -779,13 +779,13 @@ public final class ToolWindowsPane extends JBLayeredPane implements UISettingsLi UISettings settings = UISettings.getInstance(); if (anchor == ToolWindowAnchor.LEFT) { if (settings.getLeftHorizontalSplit() != isSplitterHorizontalNow) { - settings.getState().setLeftHorizontalSplit(isSplitterHorizontalNow); + settings.setLeftHorizontalSplit(isSplitterHorizontalNow); settings.fireUISettingsChanged(); } } if (anchor == ToolWindowAnchor.RIGHT) { if (settings.getRightHorizontalSplit() != isSplitterHorizontalNow) { - settings.getState().setRightHorizontalSplit(isSplitterHorizontalNow); + settings.setRightHorizontalSplit(isSplitterHorizontalNow); settings.fireUISettingsChanged(); } }