From 0f82a3bf77d14ad95ec439ea5f4f7264c7b9d7f9 Mon Sep 17 00:00:00 2001 From: "Anna.Kozlova" Date: Tue, 19 Jul 2016 19:04:30 +0200 Subject: [PATCH] merge misspelled (hashCode, toString, setUp, tearDown, compareTo) inspections --- .../UnusedDeclarationInspectionMerger.java | 4 +- .../ex/InspectionProfileTest.java | 16 +++++ .../InspectionProfileEntry.java | 14 ++++ .../ex/InspectionElementsMerger.java | 48 +++++++++++++ ...java => InspectionElementsMergerBase.java} | 29 +++++--- .../ex/InspectionProfileImpl.java | 41 ++++++----- .../src/META-INF/InspectionGadgets.xml | 20 +----- .../MisspelledCompareToInspectionBase.java | 63 ---------------- .../MisspelledHashcodeInspectionBase.java | 63 ---------------- .../MisspelledToStringInspectionBase.java | 63 ---------------- .../ThrowableNeverThrownInspectionMerger.java | 4 +- .../junit/MisspelledSetUpInspectionBase.java | 72 ------------------- .../MisspelledTearDownInspectionBase.java | 72 ------------------- ...> MisspelledMethodNameInspectionBase.java} | 8 +-- ...MisspelledMethodNameInspectionMerger.java} | 21 +++--- .../ig/bugs/MisspelledHashcodeInspection.java | 28 -------- .../ig/bugs/MisspelledToStringInspection.java | 28 -------- .../ig/junit/MisspelledSetUpInspection.java | 27 ------- .../junit/MisspelledTearDownInspection.java | 27 ------- ...va => MisspelledMethodNameInspection.java} | 4 +- .../MethodNamesDifferOnlyByCase.java | 5 ++ ...odNamesDifferOnlyByCaseInspectionTest.java | 2 +- 22 files changed, 150 insertions(+), 509 deletions(-) create mode 100644 platform/analysis-api/src/com/intellij/codeInspection/ex/InspectionElementsMerger.java rename platform/analysis-impl/src/com/intellij/codeInspection/ex/{InspectionElementsMerger.java => InspectionElementsMergerBase.java} (90%) delete mode 100644 plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/bugs/MisspelledCompareToInspectionBase.java delete mode 100644 plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/bugs/MisspelledHashcodeInspectionBase.java delete mode 100644 plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/bugs/MisspelledToStringInspectionBase.java delete mode 100644 plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/junit/MisspelledSetUpInspectionBase.java delete mode 100644 plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/junit/MisspelledTearDownInspectionBase.java rename plugins/InspectionGadgets/InspectionGadgetsAnalysis/src/com/siyeh/ig/naming/{MethodNamesDifferOnlyByCaseInspectionBase.java => MisspelledMethodNameInspectionBase.java} (95%) rename plugins/InspectionGadgets/{src/com/siyeh/ig/bugs/MisspelledCompareToInspection.java => InspectionGadgetsAnalysis/src/com/siyeh/ig/naming/MisspelledMethodNameInspectionMerger.java} (52%) delete mode 100644 plugins/InspectionGadgets/src/com/siyeh/ig/bugs/MisspelledHashcodeInspection.java delete mode 100644 plugins/InspectionGadgets/src/com/siyeh/ig/bugs/MisspelledToStringInspection.java delete mode 100644 plugins/InspectionGadgets/src/com/siyeh/ig/junit/MisspelledSetUpInspection.java delete mode 100644 plugins/InspectionGadgets/src/com/siyeh/ig/junit/MisspelledTearDownInspection.java rename plugins/InspectionGadgets/src/com/siyeh/ig/naming/{MethodNamesDifferOnlyByCaseInspection.java => MisspelledMethodNameInspection.java} (89%) diff --git a/java/java-impl/src/com/intellij/codeInspection/deadCode/UnusedDeclarationInspectionMerger.java b/java/java-impl/src/com/intellij/codeInspection/deadCode/UnusedDeclarationInspectionMerger.java index 5092410f419e..75be9546415b 100644 --- a/java/java-impl/src/com/intellij/codeInspection/deadCode/UnusedDeclarationInspectionMerger.java +++ b/java/java-impl/src/com/intellij/codeInspection/deadCode/UnusedDeclarationInspectionMerger.java @@ -15,12 +15,12 @@ */ package com.intellij.codeInspection.deadCode; -import com.intellij.codeInspection.ex.InspectionElementsMerger; +import com.intellij.codeInspection.ex.InspectionElementsMergerBase; import com.intellij.codeInspection.unusedSymbol.UnusedSymbolLocalInspection; import com.intellij.openapi.util.WriteExternalException; import org.jdom.Element; -public class UnusedDeclarationInspectionMerger extends InspectionElementsMerger { +public class UnusedDeclarationInspectionMerger extends InspectionElementsMergerBase { private static final String UNUSED_SYMBOL = "UNUSED_SYMBOL"; private static final String UNUSED_DECLARATION = "UnusedDeclaration"; diff --git a/java/java-tests/testSrc/com/intellij/codeInspection/ex/InspectionProfileTest.java b/java/java-tests/testSrc/com/intellij/codeInspection/ex/InspectionProfileTest.java index 7a5002f50a7d..85b9202d71fd 100644 --- a/java/java-tests/testSrc/com/intellij/codeInspection/ex/InspectionProfileTest.java +++ b/java/java-tests/testSrc/com/intellij/codeInspection/ex/InspectionProfileTest.java @@ -360,6 +360,22 @@ public class InspectionProfileTest extends LightIdeaTestCase { ""); } + public void testMergedMisspelledInspections() throws Exception { + checkMergedNoChanges("\n" + + " "); + checkMergedNoChanges("\n" + + " "); + } + public void testDisabledUnusedDeclarationWithChanges() throws Exception { checkMergedNoChanges("\n" + "