From 0efd80e15f818459ccabdd1acb9b5997c090e2c0 Mon Sep 17 00:00:00 2001 From: Anna Kozlova Date: Thu, 21 Jan 2021 11:46:32 +0100 Subject: [PATCH] unchecked warning: keep warning for all generic class types (IDEA-259694) ignore if target type was raw, found by integration test GitOrigin-RevId: eee1c2d03c94d25f25a9e709c1f6e776383b3401 --- .../src/com/intellij/psi/util/PsiTypesUtil.java | 2 +- .../NoUncheckedWarningOnRawSubstitutor.java | 8 ++++++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/java/java-psi-api/src/com/intellij/psi/util/PsiTypesUtil.java b/java/java-psi-api/src/com/intellij/psi/util/PsiTypesUtil.java index 501124bd2421..14f9179cc6c9 100644 --- a/java/java-psi-api/src/com/intellij/psi/util/PsiTypesUtil.java +++ b/java/java-psi-api/src/com/intellij/psi/util/PsiTypesUtil.java @@ -540,7 +540,7 @@ public final class PsiTypesUtil { if (type instanceof PsiClassType) { PsiClass aClass = ((PsiClassType)type).resolveGenerics().getElement(); if (aClass instanceof PsiTypeParameter || - aClass != null && PsiUtil.typeParametersIterator(aClass).hasNext()) { + aClass != null && PsiUtil.typeParametersIterator(aClass).hasNext() && !((PsiClassType)type).isRaw()) { return true; } } diff --git a/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/advHighlighting7/NoUncheckedWarningOnRawSubstitutor.java b/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/advHighlighting7/NoUncheckedWarningOnRawSubstitutor.java index c0ad531f7b4b..816868f7593e 100644 --- a/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/advHighlighting7/NoUncheckedWarningOnRawSubstitutor.java +++ b/java/java-tests/testData/codeInsight/daemonCodeAnalyzer/advHighlighting7/NoUncheckedWarningOnRawSubstitutor.java @@ -24,3 +24,11 @@ class Bar2 { return null; } } + +class Bar3<K> { + class Foo<T> {} + void m(Foo rawFoo) {} + void n(Bar3 b, Foo rawFoo) { + b.m(rawFoo); + } +} \ No newline at end of file