From 0ef56478924f875f7fcc94d4452c8ec0e69fc183 Mon Sep 17 00:00:00 2001 From: Alexander Zolotov Date: Mon, 5 May 2014 22:40:30 +0400 Subject: [PATCH] Cleanup emmet generator --- .../template/emmet/ZenCodingTemplate.java | 7 ++----- .../emmet/generators/XmlZenCodingGenerator.java | 15 --------------- .../emmet/generators/ZenCodingGenerator.java | 6 ------ 3 files changed, 2 insertions(+), 26 deletions(-) diff --git a/xml/impl/src/com/intellij/codeInsight/template/emmet/ZenCodingTemplate.java b/xml/impl/src/com/intellij/codeInsight/template/emmet/ZenCodingTemplate.java index 56e0bf2a137e..5402fe7b122d 100644 --- a/xml/impl/src/com/intellij/codeInsight/template/emmet/ZenCodingTemplate.java +++ b/xml/impl/src/com/intellij/codeInsight/template/emmet/ZenCodingTemplate.java @@ -28,10 +28,7 @@ import com.intellij.codeInsight.template.emmet.nodes.*; import com.intellij.codeInsight.template.emmet.tokens.TemplateToken; import com.intellij.codeInsight.template.emmet.tokens.TextToken; import com.intellij.codeInsight.template.emmet.tokens.ZenCodingToken; -import com.intellij.codeInsight.template.impl.TemplateImpl; -import com.intellij.codeInsight.template.impl.TemplateManagerImpl; -import com.intellij.codeInsight.template.impl.TemplateSettings; -import com.intellij.codeInsight.template.impl.TemplateState; +import com.intellij.codeInsight.template.impl.*; import com.intellij.diagnostic.AttachmentFactory; import com.intellij.ide.IdeEventQueue; import com.intellij.ide.util.PropertiesComponent; @@ -513,7 +510,7 @@ public class ZenCodingTemplate extends CustomLiveTemplateBase { CompletionResultSet resultSet = result.withPrefixMatcher(result.getPrefixMatcher().cloneWithPrefix(templatePrefix)); resultSet.restartCompletionOnPrefixChange(StandardPatterns.string().startsWith(templatePrefix)); - resultSet.addElement(generator.createLookupElement(this, template)); + resultSet.addElement(new CustomLiveTemplateLookupElement(this, template.getKey(), template.getKey(), template.getDescription(), true, true)); } } } diff --git a/xml/impl/src/com/intellij/codeInsight/template/emmet/generators/XmlZenCodingGenerator.java b/xml/impl/src/com/intellij/codeInsight/template/emmet/generators/XmlZenCodingGenerator.java index 9ac35a5b2a88..24f322ba920e 100644 --- a/xml/impl/src/com/intellij/codeInsight/template/emmet/generators/XmlZenCodingGenerator.java +++ b/xml/impl/src/com/intellij/codeInsight/template/emmet/generators/XmlZenCodingGenerator.java @@ -15,10 +15,7 @@ */ package com.intellij.codeInsight.template.emmet.generators; -import com.intellij.application.options.emmet.EmmetOptions; -import com.intellij.codeInsight.template.CustomLiveTemplateBase; import com.intellij.codeInsight.template.emmet.tokens.TemplateToken; -import com.intellij.codeInsight.template.impl.CustomLiveTemplateLookupElement; import com.intellij.codeInsight.template.impl.TemplateImpl; import com.intellij.openapi.util.Pair; import com.intellij.psi.PsiElement; @@ -79,16 +76,4 @@ public abstract class XmlZenCodingGenerator extends ZenCodingGenerator { int totalIterations, @Nullable String surroundedText); public abstract boolean isMyContext(@NotNull PsiElement context, boolean wrapping); - - @Override - public CustomLiveTemplateLookupElement createLookupElement(@NotNull CustomLiveTemplateBase customLiveTemplate, - @NotNull final TemplateImpl template) { - return new CustomLiveTemplateLookupElement(customLiveTemplate, template.getKey(), template.getDescription(), "", false, true); - } - - @Override - public boolean hasCompletionItem() { - EmmetOptions emmetOptions = EmmetOptions.getInstance(); - return emmetOptions.isEmmetEnabled() && emmetOptions.isPreviewEnabled(); - } } diff --git a/xml/impl/src/com/intellij/codeInsight/template/emmet/generators/ZenCodingGenerator.java b/xml/impl/src/com/intellij/codeInsight/template/emmet/generators/ZenCodingGenerator.java index 7c04edd646df..4e1dbdf31d9b 100644 --- a/xml/impl/src/com/intellij/codeInsight/template/emmet/generators/ZenCodingGenerator.java +++ b/xml/impl/src/com/intellij/codeInsight/template/emmet/generators/ZenCodingGenerator.java @@ -15,14 +15,12 @@ */ package com.intellij.codeInsight.template.emmet.generators; -import com.intellij.codeInsight.template.CustomLiveTemplateBase; import com.intellij.codeInsight.template.CustomTemplateCallback; import com.intellij.codeInsight.template.emmet.EmmetParser; import com.intellij.codeInsight.template.emmet.XmlEmmetParser; import com.intellij.codeInsight.template.emmet.ZenCodingTemplate; import com.intellij.codeInsight.template.emmet.tokens.TemplateToken; import com.intellij.codeInsight.template.emmet.tokens.ZenCodingToken; -import com.intellij.codeInsight.template.impl.CustomLiveTemplateLookupElement; import com.intellij.codeInsight.template.impl.TemplateImpl; import com.intellij.openapi.editor.Editor; import com.intellij.openapi.extensions.ExtensionPointName; @@ -185,8 +183,4 @@ public abstract class ZenCodingGenerator { public boolean hasCompletionItem() { return false; } - - public CustomLiveTemplateLookupElement createLookupElement(@NotNull CustomLiveTemplateBase customLiveTemplate, @NotNull TemplateImpl template) { - return new CustomLiveTemplateLookupElement(customLiveTemplate, template.getKey(), template.getKey(), template.getDescription(), true, true); - } }