From 9c46a51dc17d29948609c6359d7222f52df80cb4 Mon Sep 17 00:00:00 2001 From: Roman Shevchenko Date: Tue, 29 Apr 2014 20:51:08 +0400 Subject: [PATCH 1/3] Cleanup (arrangement; warns in default logger) --- .../openapi/diagnostic/DefaultLogger.java | 53 +++++++++---------- 1 file changed, 25 insertions(+), 28 deletions(-) diff --git a/platform/util/src/com/intellij/openapi/diagnostic/DefaultLogger.java b/platform/util/src/com/intellij/openapi/diagnostic/DefaultLogger.java index dac5a4969640..333975d425ff 100644 --- a/platform/util/src/com/intellij/openapi/diagnostic/DefaultLogger.java +++ b/platform/util/src/com/intellij/openapi/diagnostic/DefaultLogger.java @@ -1,5 +1,5 @@ /* - * Copyright 2000-2009 JetBrains s.r.o. + * Copyright 2000-2014 JetBrains s.r.o. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -21,8 +21,8 @@ import org.jetbrains.annotations.NotNull; import org.jetbrains.annotations.Nullable; public class DefaultLogger extends Logger { - public DefaultLogger(String category) { - } + @SuppressWarnings("UnusedParameters") + public DefaultLogger(String category) { } @Override public boolean isDebugEnabled() { @@ -30,22 +30,32 @@ public class DefaultLogger extends Logger { } @Override - public void debug(String message) { + public void debug(String message) { } + + @Override + public void debug(Throwable t) { } + + @Override + public void debug(@NonNls String message, Throwable t) { } + + @Override + public void info(String message) { } + + @Override + public void info(String message, Throwable t) { } + + @Override + @SuppressWarnings("UseOfSystemOutOrSystemErr") + public void warn(@NonNls String message, @Nullable Throwable t) { + System.err.println("WARN: " + message); + if (t != null) t.printStackTrace(System.err); } @Override - public void debug(Throwable t) { - } - - @Override - public void debug(@NonNls String message, Throwable t) { - } - - @Override - @SuppressWarnings({"HardCodedStringLiteral", "UseOfSystemOutOrSystemErr", "CallToPrintStackTrace"}) + @SuppressWarnings("UseOfSystemOutOrSystemErr") public void error(String message, @Nullable Throwable t, @NotNull String... details) { System.err.println("ERROR: " + message); - if (t != null) t.printStackTrace(); + if (t != null) t.printStackTrace(System.err); if (details.length > 0) { System.out.println("details: "); for (String detail : details) { @@ -59,18 +69,5 @@ public class DefaultLogger extends Logger { } @Override - public void info(String message) { - } - - @Override - public void info(String message, Throwable t) { - } - - @Override - public void warn(@NonNls String message, Throwable t) { - } - - @Override - public void setLevel(Level level) { - } + public void setLevel(Level level) { } } From 779ebf13bf860a5eda34fedb011d0907b2be41ec Mon Sep 17 00:00:00 2001 From: peter Date: Tue, 29 Apr 2014 18:39:34 +0200 Subject: [PATCH 2/3] save some invokeLater's in progress text2 updating --- .../intellij/openapi/wm/impl/status/InfoAndProgressPanel.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/platform/platform-impl/src/com/intellij/openapi/wm/impl/status/InfoAndProgressPanel.java b/platform/platform-impl/src/com/intellij/openapi/wm/impl/status/InfoAndProgressPanel.java index 065e76804bc1..fef7d1bbe6f8 100644 --- a/platform/platform-impl/src/com/intellij/openapi/wm/impl/status/InfoAndProgressPanel.java +++ b/platform/platform-impl/src/com/intellij/openapi/wm/impl/status/InfoAndProgressPanel.java @@ -649,7 +649,7 @@ public class InfoAndProgressPanel extends JPanel implements CustomStatusBarWidge myUpdateQueue.queue(new Update(MyInlineProgressIndicator.this, false, 1) { @Override public void run() { - ApplicationManager.getApplication().invokeLater(update); + update.run(); } }); } From ef226f6b638e3b902e38526c842ae57fb77866e2 Mon Sep 17 00:00:00 2001 From: "Gregory.Shrago" Date: Tue, 29 Apr 2014 21:33:10 +0400 Subject: [PATCH 3/3] restore extra space trimmed by fitInsideEditor() --- .../src/com/intellij/injected/editor/EditorWindowImpl.java | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/platform/lang-impl/src/com/intellij/injected/editor/EditorWindowImpl.java b/platform/lang-impl/src/com/intellij/injected/editor/EditorWindowImpl.java index 4b0d9d158385..0b077fa72fde 100644 --- a/platform/lang-impl/src/com/intellij/injected/editor/EditorWindowImpl.java +++ b/platform/lang-impl/src/com/intellij/injected/editor/EditorWindowImpl.java @@ -417,7 +417,12 @@ public class EditorWindowImpl extends UserDataHolderBase implements EditorWindow @NotNull public Point logicalPositionToXY(@NotNull final LogicalPosition pos) { assert isValid(); - return myDelegate.logicalPositionToXY(injectedToHost(fitInsideEditor(pos))); + LogicalPosition trimmedPos = fitInsideEditor(pos); + LogicalPosition hostPos = injectedToHost(trimmedPos); + if (!trimmedPos.equals(pos)) { + hostPos = new LogicalPosition(hostPos.line + (pos.line - trimmedPos.line), hostPos.column + (pos.column - trimmedPos.column)); + } + return myDelegate.logicalPositionToXY(hostPos); } @Override