From 0d09220b82fb0feb7ecffb0ec98db3f4cd96c306 Mon Sep 17 00:00:00 2001 From: Sergei Tachenov Date: Mon, 22 Jun 2026 16:41:05 +0300 Subject: [PATCH] [UI, Problems] IJPL-242950 Make the toolbar always visible Remove the corresponding state property, as it's always visible now. Reviewed at IJ-CR-209740. (cherry picked from commit b87d97113c2578d741d9764f5cc0ab8f74a5b006) GitOrigin-RevId: 97c2433d4baf570025162b512ea3436ef3f1c0c6 --- platform/lang-impl/api-dump-unreviewed.txt | 2 -- .../intellij/analysis/problemsView/toolWindow/ProblemsView.java | 2 -- .../analysis/problemsView/toolWindow/ProblemsViewPanel.java | 1 - .../analysis/problemsView/toolWindow/ProblemsViewState.kt | 1 - 4 files changed, 6 deletions(-) diff --git a/platform/lang-impl/api-dump-unreviewed.txt b/platform/lang-impl/api-dump-unreviewed.txt index 8f266d5f5f9f..ad0f35aae32b 100644 --- a/platform/lang-impl/api-dump-unreviewed.txt +++ b/platform/lang-impl/api-dump-unreviewed.txt @@ -126,7 +126,6 @@ c:com.intellij.analysis.problemsView.toolWindow.ProblemsViewState - f:getProportion():F - f:getSelectedTabId():java.lang.String - f:getShowPreview():Z -- f:getShowToolbar():Z - f:getSortFoldersFirst():Z - f:removeAllSeverities(java.util.Collection):Z - f:removeSeverity(I):Z @@ -135,7 +134,6 @@ c:com.intellij.analysis.problemsView.toolWindow.ProblemsViewState - f:setProportion(F):V - f:setSelectedTabId(java.lang.String):V - f:setShowPreview(Z):V -- f:setShowToolbar(Z):V - f:setSortFoldersFirst(Z):V f:com.intellij.analysis.problemsView.toolWindow.ProblemsViewToolWindowUtils - sf:INSTANCE:com.intellij.analysis.problemsView.toolWindow.ProblemsViewToolWindowUtils diff --git a/platform/lang-impl/src/com/intellij/analysis/problemsView/toolWindow/ProblemsView.java b/platform/lang-impl/src/com/intellij/analysis/problemsView/toolWindow/ProblemsView.java index ddcea7b45627..e5129335fd26 100644 --- a/platform/lang-impl/src/com/intellij/analysis/problemsView/toolWindow/ProblemsView.java +++ b/platform/lang-impl/src/com/intellij/analysis/problemsView/toolWindow/ProblemsView.java @@ -1,7 +1,6 @@ // Copyright 2000-2024 JetBrains s.r.o. and contributors. Use of this source code is governed by the Apache 2.0 license. package com.intellij.analysis.problemsView.toolWindow; -import com.intellij.ide.actions.ToggleToolbarAction; import com.intellij.openapi.application.ApplicationManager; import com.intellij.openapi.editor.Document; import com.intellij.openapi.editor.ex.RangeHighlighterEx; @@ -158,7 +157,6 @@ public final class ProblemsView implements DumbAware, ToolWindowFactory { public void createToolWindowContent(@NotNull Project project, @NotNull ToolWindow window) { ThreadingAssertions.assertEventDispatchThread(); ProblemsViewState state = ProblemsViewState.getInstance(project); - state.setShowToolbar(ToggleToolbarAction.isToolbarVisible(window, project)); ContentManager manager = window.getContentManager(); CompletableFuture result = CompletableFuture.completedFuture(null); diff --git a/platform/lang-impl/src/com/intellij/analysis/problemsView/toolWindow/ProblemsViewPanel.java b/platform/lang-impl/src/com/intellij/analysis/problemsView/toolWindow/ProblemsViewPanel.java index 277851f33319..2fb60574a98f 100644 --- a/platform/lang-impl/src/com/intellij/analysis/problemsView/toolWindow/ProblemsViewPanel.java +++ b/platform/lang-impl/src/com/intellij/analysis/problemsView/toolWindow/ProblemsViewPanel.java @@ -222,7 +222,6 @@ public class ProblemsViewPanel extends OnePixelSplitter implements Disposable, U JComponent centerComponent = createCenterComponent(); myToolbar = createToolbar(); myToolbar.setTargetComponent(centerComponent); - myToolbar.getComponent().setVisible(state.getShowToolbar()); myPanel = new JPanel(new BorderLayout()); myScrollPane = createScrollPane(centerComponent, true); if (ExperimentalUI.isNewUI()) { diff --git a/platform/lang-impl/src/com/intellij/analysis/problemsView/toolWindow/ProblemsViewState.kt b/platform/lang-impl/src/com/intellij/analysis/problemsView/toolWindow/ProblemsViewState.kt index 03924b435b19..16dd8280eb1d 100644 --- a/platform/lang-impl/src/com/intellij/analysis/problemsView/toolWindow/ProblemsViewState.kt +++ b/platform/lang-impl/src/com/intellij/analysis/problemsView/toolWindow/ProblemsViewState.kt @@ -24,7 +24,6 @@ open class ProblemsViewState : BaseState() { var autoscrollToSource: Boolean by property(false) var showPreview: Boolean by property(false) - var showToolbar: Boolean by property(true) var groupByToolId: Boolean by property(false) var sortFoldersFirst: Boolean by property(true)